Add EXCEPTION-FILE and EXCEPTION-LOCATION #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
September 4, 2023 16:17
This reverts commit c238e73.
Comment on lines
1943
to
1944
| data = String.valueOf(' '); | ||
| currField.memcpy(data.getBytes(), 1); |
Contributor
There was a problem hiding this comment.
下記のように変更してはどうでしょうか。
currField.getDataStorage().setByte(0, ' ');このように変更した場合、変数dataが未使用になるので、変数dataの宣言も削除してください
| || (CobolRuntimeException.getExceptionCode() & 0x0500) != 0x0500) { | ||
| field.setSize(2); | ||
| makeFieldEntry(field); | ||
| currField.memcpy("00", 2); |
Contributor
There was a problem hiding this comment.
memcpyの内部で"00"からbyte[]への変換が発生します。
文字列からbyte[]への変換は性能への影響が大きい場合があるので、改善してください。
例えば、
//メンバ変数の宣言
private static final byte[] byteArray00 = "00".getBytes():
//データのコピー
currField.memcpy(byteArray00, 2);または、
CobolDataStorage storage = currField.getDataStorage();
storage.setByte(0, '0');
storage.setByte(1, '0');のように変更するのが良いと考えます。
Contributor
Author
|
レビューの内容に従ってコードを修正しました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added EXCEPTION-FILE and EXCEPTION-LOCATION in CobolIntrinsic.java.
And, New test cases were added to functions.at.