V1.0.15 #226
Merged
V1.0.15 #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mo-shimada
reviewed
Sep 29, 2023
CONTRIBUTING.md
Outdated
|
|
||
| # Pull Requests | ||
|
|
||
| We will check pull requests which pass all CI checks which run tests and static code analysis. |
Contributor
There was a problem hiding this comment.
We will check pull requests that passed all CI checks running both tests and static code analysis.
CONTRIBUTING.md
Outdated
| # Pull Requests | ||
|
|
||
| We will check pull requests which pass all CI checks which run tests and static code analysis. | ||
| The static analysis checks whether C and Java source files are respectively formated with [clang-format](https://clang.llvm.org/docs/ClangFormat.html) and [google-java-format](https://github.com/google/google-java-format) and [PMD](https://pmd.github.io/) finds no error and warning in Java source files. |
Contributor
There was a problem hiding this comment.
The static analysis checks whether C and Java source files are formatted using clang-format and google-java-format respectively, and whether PMD finds no error and warning in Java source files.
- formated→formatted
- formatedとの明確な違いは不明ですが、formattedの方が、より一般的かと思いました。
CONTRIBUTING.md
Outdated
| ### clang-format and google-java-format | ||
|
|
||
| Run `./format` in the top directory of opensource COBOL 4J. | ||
| If you would like to check whether all files are formated, run `./check-format` in the top directory of opensource COBOL 4J. |
Contributor
There was a problem hiding this comment.
If you want to make sure all files are formatted, …
CONTRIBUTING.md
Outdated
|
|
||
| ### google-java-format | ||
|
|
||
| Run the following command to download `google-java-format`. |
Contributor
There was a problem hiding this comment.
Run the following command ... と続く場合はピリオドでなく、コロン( : )で終わるのも良いかと思います。
好みの問題だと思いますので、坂本さんのお好きな方を採用してください。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release v1.0.15