-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark theme for opensourcediversity #118
base: main
Are you sure you want to change the base?
Conversation
Please review my PR and let me know if any changes are to be made. |
Hi @siddhanth339, good stuff! :) Here’s some points:
What do you think? :) |
Good idea! I am working on it and will make a commit soon. Thanks for your time! |
@jancborchardt please review my latest commit 1f42523
|
@jancborchardt any updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siddhanth339 nice! Some feedback:
- Removing the color completely seems a bit harsh, I would say the top part works nice in the green too? And the dividers would be nice with the dash of color as well. What do you think?
- Can you check the conflicts with current main branch and resolve them? A lot of this might be because of the tabs to spaces conversion
A glimpse of the dark theme:
Also, some links were unnecessary so I have fixed them.