add 'const' keyword to generated constants #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds the 'const' keyword to constant definitions generated by the compiler. Previously the compiler generated constants like this: foo.h ====== extern int foo; foo.c ====== int foo = 5; With this patch, the generated code looks like: foo.h ====== extern const int foo; foo.c ====== const int foo = 5; Signed-off-by: Curt Brune <curt@enfabrica.net>
When working with integer constants, it is convenient to use #define macros for the constants, as opposed to a variable of constant type. This patch adds a '#define CONSTANT (value)' definition to the generated header files. The name of the constant is in SCREAMING_SNAKE_CASE, converted from the regular camelCase. Signed-off-by: Curt Brune <curt@enfabrica.net>
|
Broke the build, reverted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the
constkeyword to constant definitions generated by the compiler. Previously the compiler generated constants like this:foo.h
foo.c
With this patch, the generated code looks like:
foo.h
foo.c