Skip to content

Commit

Permalink
Merge pull request FRRouting#13889 from chiragshah6/fdev2
Browse files Browse the repository at this point in the history
tools: fix pim interface config deletion
  • Loading branch information
idryzhov authored Jul 4, 2023
2 parents e8996e1 + 623af04 commit c411512
Showing 1 changed file with 34 additions and 1 deletion.
35 changes: 34 additions & 1 deletion tools/frr-reload.py
Original file line number Diff line number Diff line change
Expand Up @@ -891,7 +891,7 @@ def bgp_remove_neighbor_cfg(lines_to_del, del_nbr_dict):
lines_to_del.remove((ctx_keys, line))


def delete_move_lines(lines_to_add, lines_to_del):
def bgp_delete_move_lines(lines_to_add, lines_to_del):
# This method handles deletion of bgp peer group config.
# The objective is to delete config lines related to peers
# associated with the peer-group and move the peer-group
Expand Down Expand Up @@ -1066,6 +1066,39 @@ def delete_move_lines(lines_to_add, lines_to_del):
return (lines_to_add, lines_to_del)


def pim_delete_move_lines(lines_to_add, lines_to_del):

# Under interface context, if 'no ip pim' is present
# remove subsequent 'no ip pim <blah>' options as it
# they are implicitly deleted by 'no ip pim'.
# Remove all such depdendent options from delete
# pending list.
pim_disable = False

for (ctx_keys, line) in lines_to_del:
if ctx_keys[0].startswith("interface") and line and line == "ip pim":
pim_disable = True

if pim_disable:
for (ctx_keys, line) in lines_to_del:
if (
ctx_keys[0].startswith("interface")
and line
and line.startswith("ip pim ")
):
lines_to_del.remove((ctx_keys, line))

return (lines_to_add, lines_to_del)


def delete_move_lines(lines_to_add, lines_to_del):

lines_to_add, lines_to_del = bgp_delete_move_lines(lines_to_add, lines_to_del)
lines_to_add, lines_to_del = pim_delete_move_lines(lines_to_add, lines_to_del)

return (lines_to_add, lines_to_del)


def ignore_delete_re_add_lines(lines_to_add, lines_to_del):

# Quite possibly the most confusing (while accurate) variable names in history
Expand Down

0 comments on commit c411512

Please sign in to comment.