forked from FRRouting/frr
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topotato: Assert Ping #133
Open
eznix86
wants to merge
2
commits into
topotato-base
Choose a base branch
from
topotato-assert-ping
base: topotato-base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Bernard <contact.brunobernard@gmail.com>
eqvinox
reviewed
Sep 15, 2023
Signed-off-by: Bruno Bernard <contact.brunobernard@gmail.com>
Updated the code, it seems like I do not receive the expected packet with IP/ICMP (tried with ScapySend + AssertPacket Combination) and remained the same results: E topotato.exceptions.TopotatoPacketFail: did not receive a matching packet for:
E def expect_pkt(ip: IP, icmp: ICMP):
E return True
/home/vagrant/dev/topotato/test_ping.py:47: TopotatoPacketFail
-------------------------------------------------------------- Captured log call --------------------------------------------------------------
DEBUG root:assertions.py:381 element: {'match_for': [], '_pkt': <Ether dst=33:33:00:00:00:16 src=fe:02:00:bc:01:00 type=IPv6 |<IPv6 version=6 tc=0 fl=0 plen=76 nh=Hop-by-Hop Option Header hlim=1 src=fe80::fc02:ff:febc:100 dst=ff02::16 |<IPv6ExtHdrHopByHop nh=ICMPv6 len=0 autopad=On options=[<RouterAlert otype=Router Alert [00: skip, 0: Don't change en-route] optlen=2 value=Datagram contains a MLD message |>, <PadN otype=PadN [00: skip, 0: Don't change en-route] optlen=0 |>] |<ICMPv6MLReport2 type=MLD Report Version 2 res=0 cksum=0x6d5a reserved=0 records_number=3 records=[<ICMPv6MLDMultAddrRec rtype=4 auxdata_len=0 sources_number=0 dst=ff02::1:ff00:0 auxdata='' |<ICMPv6MLDMultAddrRec rtype=4 auxdata_len=0 sources_number=0 dst=ff02::1:ffbc:100 auxdata='' |<ICMPv6MLDMultAddrRec rtype=4 auxdata_len=0 sources_number=0 dst=ff02::2 |>>>] |>>>>}
DEBUG root:assertions.py:386 element: {'match_for': [], '_pkt': <Ether dst=33:33:00:00:00:16 src=fe:02:00:bc:01:00 type=IPv6 |<IPv6 version=6 tc=0 fl=0 plen=76 nh=Hop-by-Hop Option Header hlim=1 src=fe80::fc02:ff:febc:100 dst=ff02::16 |<IPv6ExtHdrHopByHop nh=ICMPv6 len=0 autopad=On options=[<RouterAlert otype=Router Alert [00: skip, 0: Don't change en-route] optlen=2 value=Datagram contains a MLD message |>, <PadN otype=PadN [00: skip, 0: Don't change en-route] optlen=0 |>] |<ICMPv6MLReport2 type=MLD Report Version 2 res=0 cksum=0x6d5a reserved=0 records_number=3 records=[<ICMPv6MLDMultAddrRec rtype=4 auxdata_len=0 sources_number=0 dst=ff02::1:ff00:0 auxdata='' |<ICMPv6MLDMultAddrRec rtype=4 auxdata_len=0 sources_number=0 dst=ff02::1:ffbc:100 auxdata='' |<ICMPv6MLDMultAddrRec rtype=4 auxdata_len=0 sources_number=0 dst=ff02::2 |>>>] |>>>>}
DEBUG root:assertions.py:381 element: {'match_for': [], '_pkt': <Ether dst=33:33:00:00:00:16 src=fe:02:00:bc:01:00 type=IPv6 |<IPv6 version=6 tc=0 fl=0 plen=76 nh=Hop-by-Hop Option Header hlim=1 src=fe80::fc02:ff:febc:100 dst=ff02::16 |<IPv6ExtHdrHopByHop nh=ICMPv6 len=0 autopad=On options=[<RouterAlert otype=Router Alert [00: skip, 0: Don't change en-route] optlen=2 value=Datagram contains a MLD message |>, <PadN otype=PadN [00: skip, 0: Don't change en-route] optlen=0 |>] |<ICMPv6MLReport2 type=MLD Report Version 2 res=0 cksum=0x6d5a reserved=0 records_number=3 records=[<ICMPv6MLDMultAddrRec rtype=4 auxdata_len=0 sources_number=0 dst=ff02::1:ff00:0 auxdata='' |<ICMPv6MLDMultAddrRec rtype=4 auxdata_len=0 sources_number=0 dst=ff02::1:ffbc:100 auxdata='' |<ICMPv6MLDMultAddrRec rtype=4 auxdata_len=0 sources_number=0 dst=ff02::2 |>>>] |>>>>}
DEBUG root:assertions.py:386 element: {'match_for': [], '_pkt': <Ether dst=33:33:00:00:00:16 src=fe:02:00:bc:01:00 type=IPv6 |<IPv6 version=6 tc=0 fl=0 plen=76 nh=Hop-by-Hop Option Header hlim=1 src=fe80::fc02:ff:febc:100 dst=ff02::16 |<IPv6ExtHdrHopByHop nh=ICMPv6 len=0 autopad=On options=[<RouterAlert otype=Router Alert [00: skip, 0: Don't change en-route] optlen=2 value=Datagram contains a MLD message |>, <PadN otype=PadN [00: skip, 0: Don't change en-route] optlen=0 |>] |<ICMPv6MLReport2 type=MLD Report Version 2 res=0 cksum=0x6d5a reserved=0 records_number=3 records=[<ICMPv6MLDMultAddrRec rtype=4 auxdata_len=0 sources_number=0 dst=ff02::1:ff00:0 auxdata='' |<ICMPv6MLDMultAddrRec rtype=4 auxdata_len=0 sources_number=0 dst=ff02::1:ffbc:100 auxdata='' |<ICMPv6MLDMultAddrRec rtype=4 auxdata_len=0 sources_number=0 dst=ff02::2 |>>>] |>>>>}
DEBUG root:assertions.py:381 element: {'match_for': [], '_pkt': <Ether dst=33:33:00:00:00:16 src=fe:01:00:bc:01:00 type=IPv6 |<IPv6 version=6 tc=0 fl=0 plen=76 nh=Hop-by-Hop Option Header hlim=1 src=fe80::fc01:ff:febc:100 dst=ff02::16 |<IPv6ExtHdrHopByHop nh=ICMPv6 len=0 autopad=On options=[<RouterAlert otype=Router Alert [00: skip, 0: Don't change en-route] optlen=2 value=Datagram contains a MLD message |>, <PadN otype=PadN [00: skip, 0: Don't change en-route] optlen=0 |>] |<ICMPv6MLReport2 type=MLD Report Version 2 res=0 cksum=0x6d5b reserved=0 records_number=3 records=[<ICMPv6MLDMultAddrRec rtype=4 auxdata_len=0 sources_number=0 dst=ff02::1:ff00:0 auxdata='' |<ICMPv6MLDMultAddrRec rtype=4 auxdata_len=0 sources_number=0 dst=ff02::1:ffbc:100 auxdata='' |<ICMPv6MLDMultAddrRec rtype=4 auxdata_len=0 sources_number=0 dst=ff02::2 |>>>] |>>>>}
DEBUG root:assertions.py:386 element: {'match_for': [], '_pkt': <Ether dst=33:33:00:00:00:16 src=fe:01:00:bc:01:00 type=IPv6 |<IPv6 version=6 tc=0 fl=0 plen=76 nh=Hop-by-Hop Option Header hlim=1 src=fe80::fc01:ff:febc:100 dst=ff02::16 |<IPv6ExtHdrHopByHop nh=ICMPv6 len=0 autopad=On options=[<RouterAlert otype=Router Alert [00: skip, 0: Don't change en-route] optlen=2 value=Datagram contains a MLD message |>, <PadN otype=PadN [00: skip, 0: Don't change en-route] optlen=0 |>] |<ICMPv6MLReport2 type=MLD Report Version 2 res=0 cksum=0x6d5b reserved=0 records_number=3 records=[<ICMPv6MLDMultAddrRec rtype=4 auxdata_len=0 sources_number=0 dst=ff02::1:ff00:0 auxdata='' |<ICMPv6MLDMultAddrRec rtype=4 auxdata_len=0 sources_number=0 dst=ff02::1:ffbc:100 auxdata='' |<ICMPv6MLDMultAddrRec rtype=4 auxdata_len=0 sources_number=0 dst=ff02::2 |>>>] |>>>>}
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested yet, but waiting for a review on implementation.
implementation:
yield from AssertPing.make(r1, iface, r2)