Skip to content

Commit

Permalink
fix: incorrect letter case of section filter #963 (#964)
Browse files Browse the repository at this point in the history
  • Loading branch information
hyifeng authored Oct 9, 2024
1 parent c616bea commit 649e247
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 19 deletions.
6 changes: 3 additions & 3 deletions site/src/components/calls/filter/index.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import { useTimeDimensionFilterItems } from "../../../utils/hooks/useTimeDimensionFilterItems";
import CombinedFilter from "../../filter/combinedFilter";
import { useCallSecondMethodFilter } from "./useCallSecondMethodFilter";
import { useCallSectionMethodFilter } from "./useCallSectionMethodFilter";

export default function CallFilter() {
const secondMethodFilters = useCallSecondMethodFilter();
const sectionMethodFilters = useCallSectionMethodFilter();
const timeDimensionFilters = useTimeDimensionFilterItems();
return (
<CombinedFilter
filters1={secondMethodFilters}
filters1={sectionMethodFilters}
filters2={timeDimensionFilters}
/>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
fetchSpecsFilter,
filtersSelector,
} from "../../../store/reducers/filterSlice";
import { stringCamelCase, stringLowerFirst } from "@polkadot/util";
import { stringCamelCase } from "@polkadot/util";
import {
AllOption,
getFromQuery,
Expand Down Expand Up @@ -58,7 +58,7 @@ function getSectionDescendant(section) {
};
}

export function useCallSecondMethodFilter() {
export function useCallSectionMethodFilter() {
const dispatch = useDispatch();
const location = useLocation();
const specFilters = useSelector(filtersSelector);
Expand Down Expand Up @@ -95,7 +95,7 @@ export function useCallSecondMethodFilter() {
sectionQueryValue,
(
sectionOptions.find(
(section) => stringLowerFirst(section.name) === sectionQueryValue,
(section) => stringCamelCase(section.name) === sectionQueryValue,
) ?? { calls: [] }
).calls,
);
Expand Down Expand Up @@ -124,7 +124,7 @@ export function useCallSecondMethodFilter() {
sectionOptions.map((section) => {
return {
text: section.name,
value: stringLowerFirst(section.name),
value: stringCamelCase(section.name),
descendant: getSectionDescendant(section),
};
}),
Expand Down
4 changes: 2 additions & 2 deletions site/src/components/events/filter/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ import { useTimeDimensionFilterItems } from "../../../utils/hooks/useTimeDimensi
import CombinedFilter from "../../filter/combinedFilter";

export default function EventFilter() {
const secondMethodFilters = useEventSectionMethodFilter();
const sectionMethodFilters = useEventSectionMethodFilter();
const timeDimensionFilters = useTimeDimensionFilterItems();
return (
<CombinedFilter
filters1={secondMethodFilters}
filters1={sectionMethodFilters}
filters2={timeDimensionFilters}
/>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
} from "../../../store/reducers/filterSlice";
import { useEffect, useState } from "react";
import { useLocation } from "react-router-dom";
import { stringLowerFirst } from "@polkadot/util";
import { stringCamelCase } from "@polkadot/util";
import {
AllOption,
getFromQuery,
Expand Down Expand Up @@ -106,7 +106,7 @@ export function useEventSectionMethodFilter() {
sectionValue,
(
sectionOptions.find(
(section) => stringLowerFirst(section.name) === sectionValue,
(section) => stringCamelCase(section.name) === sectionValue,
) ?? { events: [] }
).events,
);
Expand Down Expand Up @@ -135,7 +135,7 @@ export function useEventSectionMethodFilter() {
sectionOptions.map((section) => {
return {
text: section.name,
value: stringLowerFirst(section.name),
value: stringCamelCase(section.name),
descendant: getSectionDescendant(section),
};
}),
Expand Down
6 changes: 3 additions & 3 deletions site/src/components/extrinsics/filter/index.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import { useExtrinsicSecondMethodFilter } from "./useExtrinsicSecondMethodFilter";
import { useExtrinsicSectionMethodFilter } from "./useExtrinsicSectionMethodFilter";
import { useTimeDimensionFilterItems } from "../../../utils/hooks/useTimeDimensionFilterItems";
import CombinedFilter from "../../filter/combinedFilter";

export default function ExtrinsicFilter() {
const secondMethodFilters = useExtrinsicSecondMethodFilter();
const sectionMethodFilters = useExtrinsicSectionMethodFilter();
const timeDimensionFilters = useTimeDimensionFilterItems();
return (
<CombinedFilter
filters1={secondMethodFilters}
filters1={sectionMethodFilters}
filters2={timeDimensionFilters}
/>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
} from "../../../store/reducers/filterSlice";
import { useEffect, useState } from "react";
import { useLocation } from "react-router-dom";
import { stringCamelCase, stringLowerFirst } from "@polkadot/util";
import { stringCamelCase } from "@polkadot/util";
import {
AllOption,
getFromQuery,
Expand Down Expand Up @@ -60,7 +60,7 @@ function getSectionDescendant(section) {
};
}

export function useExtrinsicSecondMethodFilter() {
export function useExtrinsicSectionMethodFilter() {
const dispatch = useDispatch();
const location = useLocation();
const specFilters = useSelector(filtersSelector);
Expand Down Expand Up @@ -109,7 +109,7 @@ export function useExtrinsicSecondMethodFilter() {
sectionValue,
(
sectionOptions.find(
(section) => stringLowerFirst(section.name) === sectionValue,
(section) => stringCamelCase(section.name) === sectionValue,
) ?? { calls: [] }
).calls,
);
Expand Down Expand Up @@ -138,7 +138,7 @@ export function useExtrinsicSecondMethodFilter() {
sectionOptions.map((section) => {
return {
text: section.name,
value: stringLowerFirst(section.name),
value: stringCamelCase(section.name),
descendant: getSectionDescendant(section),
};
}),
Expand Down

0 comments on commit 649e247

Please sign in to comment.