Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Authentication on Sending Device #4

Closed
4 tasks done
githengi opened this issue Mar 6, 2019 · 3 comments
Closed
4 tasks done

Implement Authentication on Sending Device #4

githengi opened this issue Mar 6, 2019 · 3 comments
Assignees

Comments

@githengi
Copy link
Contributor

githengi commented Mar 6, 2019

  • After activating discovery mode Whenever notified whenever that a nearby Advertiser is found via the onEndpointFound() callback ; the camera is opened to scan QR code.

  • On Scanning QR code displayed by the receiving app, then the sender is deemed to have accepted sending data.

  • When one cancels the QR code scanning(camera), an alert dialog is presented with title Accept connection to {receiver device id} and message Confirm the code matches on both devices: {authentication code}

  • On clicking Ok, the connection is accepted otherwise connection is rejected and user is notified

@ekigamba
Copy link
Contributor

So we automatically try to connect to whichever device we find that is advertising, at which point the library tries to initiate and connection and shows the camera to check the code send?

@githengi

@githengi
Copy link
Contributor Author

Yes try to connect to whatever device is advertising. If a device is found open camera to try scan the QR code against the generated authentication token.

@ekigamba
Copy link
Contributor

There seems to be a lot of cleanup work on the UI and UX which I think should be done after the mockups are finalised. There are gaps after accepting or rejecting a connection before the other device responds. There are also gaps between any form of communication with the nearby API. At this point, the dialogs and other loading UI are already removed and the screen seems as if it is unresponsive.

@githengi Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants