Implement authentication on sending and receiving device #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add strings required by Scanner dialog
The user nickname is now the device manufacture and model
1. Add a simple texting interface on the activity 2. Show QR Code scanning dialog on connection intiation 3. Request connection to the first device that is found 4. Enable sending of simple text messages from the select mode activity 5. Add base authentication class that can be extended for more functionality 6. Add QR Code scan result authentication with current authentication token 7. Show an authentication bypass dialog if the user cancels QR code scanning 8. Handle connection lifecycle when requesting a connection -> return to discovering mode if the connection with the device fails otherwise show the simple texting UI
1. Add QR Code generation via zxing-android-embedded 2. Add ReceiverConnectionAuthenticator to show the authentication code in QR dialog 3. Add QR Code Generator Diaog 4. Add ReceiverSyncLifecycleCallback to manage lifecycle of receiver mode 5. Show QR code when a sender device initiates a connection and enable accept/reject 6. Revert to advertising if an error occurs or if the connection is rejected
Remove lint abortOnError for module p2p-sync builds
githengi
reviewed
Mar 21, 2019
p2p-sync/src/main/java/org/smartregister/p2p/activity/P2pModeSelectActivity.java
Outdated
Show resolved
Hide resolved
githengi
reviewed
Mar 21, 2019
| public abstract class BaseSyncConnectionAuthenticator { | ||
|
|
||
| protected P2pModeSelectContract.View view; | ||
| protected P2pModeSelectContract.Interactor interactor; |
There was a problem hiding this comment.
In MVP only the presenter can bind the view and interactor(model). Try to decouple this class
There was a problem hiding this comment.
Also the presenter and interactor are not used by the child classes
githengi
reviewed
Mar 21, 2019
|
|
||
| @Override | ||
| public void release() { | ||
| //Todo |
There was a problem hiding this comment.
It is supposed to release any resources being used by the processor according to https://developers.google.com/android/reference/com/google/android/gms/vision/Detector.Processor.html#release()
These are resources being used in receiveDetections. The cameraSource to which the detector is passed calls the release method
We therefore are not releasing anything in that method for our case
githengi
reviewed
Mar 21, 2019
| //Todo: Show the user an error | ||
| //Todo: Go back to advertising mode | ||
| resetState(); | ||
| view.showToast(String.format("The connection to %s has broken", endpointId), Toast.LENGTH_LONG); |
githengi
reviewed
Mar 21, 2019
| @Override | ||
| public void onRequestConnectionSuccessful(@Nullable Object result) { | ||
| // Just show a success | ||
| view.showToast("CONNECTION REQUEST WAS SUCCESSFUL", Toast.LENGTH_LONG); |
githengi
reviewed
Mar 21, 2019
| @Override | ||
| public void onRequestConnectionFailed(@NonNull Exception exception) { | ||
| // Show the user an error trying to connect device XYZ | ||
| view.showToast("COULD NOT INITIATE CONNECTION REQUEST TO THE DEVICE", Toast.LENGTH_LONG); |
githengi
reviewed
Mar 21, 2019
| if (currentReceiver != null) { | ||
| view.showToast(String.format(view.getContext().getString(R.string.you_are_connected_to_receiver), currentReceiver.getEndpointName()) | ||
| , Toast.LENGTH_LONG); | ||
| view.displayMessage("CONNECTED"); |
githengi
reviewed
Mar 21, 2019
| @Override | ||
| public void onDisconnected(@NonNull String endpointId) { | ||
| Timber.e("Endpoint lost %s", endpointId); | ||
| view.displayMessage("DISCONNECTED"); |
githengi
reviewed
Mar 21, 2019
p2p-sync/src/main/java/org/smartregister/p2p/view/QRCodeScannerView.java
Show resolved
Hide resolved
ekigamba
force-pushed
the
issue/3.4-implement-authentication-sending-receiving-devices
branch
from
dd66a55 to
fd596a8
Compare
githengi
approved these changes
Mar 22, 2019
ekigamba
deleted the
issue/3.4-implement-authentication-sending-receiving-devices
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
Fixes #5