Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add practitioner reference to Patient and Encounter resource #1087

Merged
merged 9 commits into from
Feb 25, 2022

Conversation

RaaziaTarique
Copy link
Member

@RaaziaTarique RaaziaTarique commented Feb 22, 2022

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #1057 #1058

Type
Choose one: Feature

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #1087 (3f7fee2) into main (65f5378) will increase coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1087      +/-   ##
============================================
+ Coverage     75.19%   75.22%   +0.03%     
- Complexity     1310     1312       +2     
============================================
  Files           218      218              
  Lines          8626     8635       +9     
  Branches       1304     1306       +2     
============================================
+ Hits           6486     6496      +10     
+ Misses         1215     1212       -3     
- Partials        925      927       +2     
Flag Coverage Δ
anc 78.00% <ø> (ø)
eir 68.87% <ø> (ø)
engine 74.43% <83.33%> (+0.09%) ⬆️
quest 74.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../engine/ui/questionnaire/QuestionnaireViewModel.kt 79.86% <75.00%> (-0.28%) ⬇️
.../engine/data/remote/model/response/UserResponse.kt 85.71% <100.00%> (+52.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f5378...3f7fee2. Read the comment docs.

@RaaziaTarique RaaziaTarique changed the title 1057 practitioner Add practitioner reference to Patient and Encounter resource Feb 22, 2022
@RaaziaTarique RaaziaTarique marked this pull request as ready for review February 22, 2022 14:32
@SerialName("questionnaire_publisher") var questionnairePublisher: String? = null,
@SerialName("organization") var organization: String? = null,
@SerialName("location") var location: String? = null,
@SerialName("sub") var sub: String? = null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz change the name of variable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable sub?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep to use a more descriptive name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@RaaziaTarique RaaziaTarique merged commit c6f9009 into main Feb 25, 2022
@RaaziaTarique RaaziaTarique deleted the 1057_practitioner_id branch February 25, 2022 06:48
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* - Added practitioner Id in Patient

* - Add Practitioner reference to patient and encounter resources.

* - Add test cases

* - Resolve requested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quest - Add a reference to the Practitioner while conducting a Registration Encounter
3 participants