Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANC release v0.0.5 #1129

Merged
merged 2 commits into from
Mar 21, 2022
Merged

ANC release v0.0.5 #1129

merged 2 commits into from
Mar 21, 2022

Conversation

ndegwamartin
Copy link
Contributor

Type Release

@ndegwamartin ndegwamartin requested a review from f-odhiambo March 7, 2022 06:31
@codecov
Copy link

codecov bot commented Mar 7, 2022 •
edited
Loading

Codecov Report

Merging #1129 (dbfa97a) into main (c58f13f) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1129      +/-   ##
============================================
- Coverage     74.75%   74.73%   -0.03%     
+ Complexity     1296     1293       -3     
============================================
  Files           224      224              
  Lines          8445     8445              
  Branches       1369     1369              
============================================
- Hits           6313     6311       -2     
- Misses         1148     1149       +1     
- Partials        984      985       +1
Flag Coverage Δ
anc 77.38% <ø> (ø)
eir 66.75% <ø> (ø)
engine 74.73% <ø> (-0.06%) ⬇️
quest 73.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...data/remote/fhir/resource/FhirResourceConverter.kt 75.00% <0.00%> (-25.00%) ⬇️
...data/remote/shared/interceptor/OAuthInterceptor.kt 78.57% <0.00%> (-7.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c58f13f...dbfa97a. Read the comment docs.

f-odhiambo
f-odhiambo reviewed Mar 7, 2022
View reviewed changes
Copy link
Contributor

@f-odhiambo f-odhiambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndegwamartin There are failing test, @ellykits You can have a look at these

f-odhiambo
f-odhiambo approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@f-odhiambo f-odhiambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f-odhiambo f-odhiambo merged commit 831fcd4 into main Mar 21, 2022
@f-odhiambo f-odhiambo deleted the anc-v0.0.5-release branch March 21, 2022 11:11
AbdulWahabMemon added a commit that referenced this pull request Mar 21, 2022
@AbdulWahabMemon
Merge branch '1141_remove_family_with_form' of https://github.com/ope…
0f38128 
…nsrp/fhircore into 1141_remove_family_with_form

* '1141_remove_family_with_form' of https://github.com/opensrp/fhircore:
  Preserve credentials but detroy session on logout (#1125)
  ANC release v0.0.5 (#1129)
qiarie pushed a commit that referenced this pull request Jan 15, 2025
@ndegwamartin
ANC release v0.0.5 (#1129)
531bb3f 
Adding these changes to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-odhiambo f-odhiambo f-odhiambo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndegwamartin @f-odhiambo