Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of Single APK Approach Configuration #1313

Merged
merged 69 commits into from
Jun 2, 2022

Conversation

FikriMilano
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #1284

To view the documentation in a non-raw form, open this link
https://github.com/opensrp/fhircore/blob/documenting-configurable-app/docs/configuration.md

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1313 (bf416d0) into main (9517571) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1313   +/-   ##
=========================================
  Coverage     60.00%   60.00%           
  Complexity      687      687           
=========================================
  Files           135      135           
  Lines          4691     4691           
  Branches        736      736           
=========================================
  Hits           2815     2815           
- Misses         1455     1456    +1     
+ Partials        421      420    -1     
Flag Coverage Δ
engine 60.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hircore/engine/ui/appsetting/AppSettingActivity.kt 31.81% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9517571...bf416d0. Read the comment docs.

@f-odhiambo
Copy link
Contributor

This looks good @FikriMilano . I'll give further comments later in the day . Good job

@pld pld self-assigned this May 31, 2022
docs/configuration.md Outdated Show resolved Hide resolved
@FikriMilano FikriMilano requested a review from maimoonak June 2, 2022 12:37
maimoonak
maimoonak previously approved these changes Jun 2, 2022
Copy link
Member

@pld pld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to review text before merge, blocking merge for the moment

@pld pld merged commit b4ad675 into main Jun 2, 2022
@pld pld deleted the documenting-configurable-app branch June 2, 2022 14:46
AbdulWahabMemon added a commit that referenced this pull request Jun 2, 2022
* main:
  Documentation of Single APK Approach Configuration (#1313)
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Create configuration.md

* Rename docs/configuration.md to docs/configurability/readme.md

* Update and rename app-configurability.md to bottom-nav-config.md

* Update readme.md

Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>
Co-authored-by: Peter Lubell-Doughtie <peter@ona.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] - Create Documentation of Single APK Approach Configuration
5 participants