Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1435 | handle DoB or age missing #1441

Merged
merged 11 commits into from
Jul 16, 2022
Merged

1435 | handle DoB or age missing #1441

merged 11 commits into from
Jul 16, 2022

Conversation

maimoonak
Copy link
Contributor

Fixes #1435

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #1441 (5cf5f66) into main (ea568be) will increase coverage by 0.51%.
The diff coverage is 16.66%.

@@             Coverage Diff              @@
##               main    #1441      +/-   ##
============================================
+ Coverage     38.88%   39.39%   +0.51%     
- Complexity      827      837      +10     
============================================
  Files           234      234              
  Lines          9091     9090       -1     
  Branches       1492     1496       +4     
============================================
+ Hits           3535     3581      +46     
+ Misses         5064     4999      -65     
- Partials        492      510      +18     
Flag Coverage Δ
engine 62.86% <20.00%> (+0.95%) ⬆️
quest 12.39% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/data/local/register/dao/AncPatientRegisterDao.kt 0.00% <0.00%> (ø)
.../data/local/register/dao/AppointmentRegisterDao.kt 17.64% <0.00%> (ø)
...e/engine/data/local/register/dao/HivRegisterDao.kt 69.23% <0.00%> (ø)
...rcore/quest/util/mappers/RegisterViewDataMapper.kt 1.85% <0.00%> (ø)
...ngine/data/local/register/dao/FamilyRegisterDao.kt 17.39% <50.00%> (+17.39%) ⬆️
...fhircore/engine/util/extension/PatientExtension.kt 72.81% <0.00%> (+0.97%) ⬆️
...ister/fhircore/engine/domain/model/RegisterData.kt 90.76% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea568be...5cf5f66. Read the comment docs.

pld
pld previously approved these changes Jul 15, 2022
@maimoonak maimoonak requested a review from pld July 15, 2022 20:57
@pld pld merged commit cadabf8 into main Jul 16, 2022
@pld pld deleted the 1435_dob_missing branch July 16, 2022 20:20
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Measure date filter fix

* Handle missing dob and age in family register

* Handle missng dob in other registers

* Make age non null and change age casting

* Test coverage

* Test coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Quest/eCBIS] - On HouseHold List Error -> patient DOB cannot not be null
2 participants