Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update register card #1496

Merged
merged 7 commits into from
Aug 2, 2022
Merged

Update register card #1496

merged 7 commits into from
Aug 2, 2022

Conversation

dubdabasoduba
Copy link
Member

@dubdabasoduba dubdabasoduba commented Aug 2, 2022

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[1402]

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@dubdabasoduba dubdabasoduba requested a review from ellykits August 2, 2022 16:33
@dubdabasoduba dubdabasoduba self-assigned this Aug 2, 2022
ellykits
ellykits previously approved these changes Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #1496 (e876727) into main (3eeeb9f) will decrease coverage by 26.06%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##               main    #1496       +/-   ##
=============================================
- Coverage     65.38%   39.31%   -26.07%     
- Complexity      554      587       +33     
=============================================
  Files           123      197       +74     
  Lines          4021     7544     +3523     
  Branches        698     1294      +596     
=============================================
+ Hits           2629     2966      +337     
- Misses          979     4110     +3131     
- Partials        413      468       +55     
Flag Coverage Δ
engine 65.34% <0.00%> (-0.04%) ⬇️
quest 9.57% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ngine/configuration/view/CompoundTextProperties.kt 10.00% <0.00%> (-1.12%) ⬇️
...engine/configuration/view/ServiceCardProperties.kt 11.76% <0.00%> (-0.74%) ⬇️
...rcore/quest/ui/register/components/RegisterCard.kt 0.00% <0.00%> (ø)
...egister/fhircore/quest/navigation/NavigationArg.kt 0.00% <0.00%> (ø)
...core/quest/ui/report/measure/MeasureReportEvent.kt 0.00% <0.00%> (ø)
...ort/measure/screens/MeasureReportPatientsScreen.kt 0.00% <0.00%> (ø)
...remove/family/RemoveFamilyQuestionnaireActivity.kt 0.00% <0.00%> (ø)
...est/data/report/measure/MeasureReportRepository.kt 41.17% <0.00%> (ø)
...ore/quest/ui/family/profile/FamilyProfileScreen.kt 0.00% <0.00%> (ø)
...est/ui/report/measure/ReportTypeSelectorUiState.kt 100.00% <0.00%> (ø)
... and 67 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@pld pld merged commit 6fd9d1b into main Aug 2, 2022
@pld pld deleted the update_register_card branch August 2, 2022 19:29
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* ✨ Add fontSize configuration to the register card font, update the tasks register configuration to display the patient and practitioner

* ♻️ Fix code formatting

* ✅ Update failing tests

Co-authored-by: Peter Lubell-Doughtie <peter@ona.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants