Fix issue 2036 [Configuration-Filtering registers based on resources attributes ] #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2070 +/- ##
=============================================
- Coverage 57.87% 44.34% -13.53%
+ Complexity 1038 20 -1018
=============================================
Files 219 5 -214
Lines 8462 230 -8232
Branches 1598 33 -1565
=============================================
- Hits 4897 102 -4795
+ Misses 2639 113 -2526
+ Partials 926 15 -911
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SebaMutuku
changed the title
pld
requested changes
Feb 22, 2023
There was a problem hiding this comment.
we need to rework this not have anything specific to a Practioner in it. The goal of the issue is to allow filtering or an arbitrary resource by arbitrary attributes in that resource. Looking through a code it looks this is mainly a naming problem the architecture looks like it's on the correct path overall.
I put some ideas towards that as suggested changes, I'm not sure how practitionerId generalizes, or if it's acutally needed
...ne/src/main/java/org/smartregister/fhircore/engine/data/local/register/RegisterRepository.kt
Outdated
Show resolved
Hide resolved
.../engine/src/main/java/org/smartregister/fhircore/engine/configuration/view/ListProperties.kt
Outdated
Show resolved
Hide resolved
.../engine/src/main/java/org/smartregister/fhircore/engine/configuration/view/ListProperties.kt
Outdated
Show resolved
Hide resolved
* Add Parcelizer and implement Parcelable RegisterViewModel * Add a hashmap to be used when interpolating over values and retrieve registerData ProfileViewModel * Add a hashmap to be used when interpolating over values and retrieve registerData ActionParamType *Add a Generic Data Pass identifier type
* Test load register with map containing params included * Test countRegisterData when params is passed
pld
requested changes
Mar 2, 2023
...ngine/src/main/java/org/smartregister/fhircore/engine/configuration/ConfigurationRegistry.kt
Outdated
Show resolved
Hide resolved
...ngine/src/main/java/org/smartregister/fhircore/engine/configuration/ConfigurationRegistry.kt
Outdated
Show resolved
Hide resolved
...ne/src/main/java/org/smartregister/fhircore/engine/data/local/register/RegisterRepository.kt
Outdated
Show resolved
Hide resolved
...ne/src/main/java/org/smartregister/fhircore/engine/data/local/register/RegisterRepository.kt
Show resolved
Hide resolved
...d/engine/src/main/java/org/smartregister/fhircore/engine/domain/model/ActionParameterType.kt
Outdated
Show resolved
Hide resolved
...rc/test/java/org/smartregister/fhircore/engine/data/local/register/RegisterRepositoryTest.kt
Outdated
Show resolved
Hide resolved
android/quest/src/main/java/org/smartregister/fhircore/quest/ui/register/RegisterViewModel.kt
Outdated
Show resolved
Hide resolved
...oid/quest/src/main/java/org/smartregister/fhircore/quest/util/extensions/ConfigExtensions.kt
Outdated
Show resolved
Hide resolved
* Merge branch 'main' of github.com:opensrp/fhircore into issue_1965 * Resolve conflics
SebaMutuku
added
DNM
pld
reviewed
Mar 3, 2023
android/engine/src/main/java/org/smartregister/fhircore/engine/util/ParallelUtil.kt
Outdated
Show resolved
Hide resolved
...ngine/src/main/java/org/smartregister/fhircore/engine/configuration/ConfigurationRegistry.kt
Outdated
Show resolved
Hide resolved
...ngine/src/main/java/org/smartregister/fhircore/engine/configuration/ConfigurationRegistry.kt
Outdated
Show resolved
Hide resolved
...rc/test/java/org/smartregister/fhircore/engine/data/local/register/RegisterRepositoryTest.kt
Outdated
Show resolved
Hide resolved
pld
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #2036
Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guide