-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
search functionality for map fragment #3313
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3313 +/- ##
=========================================
- Coverage 28.2% 28.2% -0.1%
- Complexity 720 727 +7
=========================================
Files 265 265
Lines 12711 12754 +43
Branches 2261 2266 +5
=========================================
+ Hits 3596 3605 +9
- Misses 8646 8679 +33
- Partials 469 470 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@ellykits this is currently in WIP state/Not finalized. |
…toring is needed.
Updating few things before marking ready for review. |
…ap_search_functionality
@ellykits I have separated the shared search functionality part from this PR, this PR only contains search functionality done on the map fragment. |
Can you reference the issue on this PR @aurangzaibumer? |
...ngine/src/main/java/org/smartregister/fhircore/engine/domain/model/TopScreenSectionConfig.kt
Show resolved
Hide resolved
done, sir. |
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
…e into map_search_functionality
Updating tests... |
Closing this PR as @ellykits worked on a new implementation which will be replaced by this. |
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes https://github.com/onaio/fhir-resources/issues/3255
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file