Engage experiment #3353
Draft
Engage experiment #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ofile post submit
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Keeping the logs, it's quite useful.
…engage-experiment
…and not close given set of tasks
This should be allowed, because an item can be hidden with skip logic, and when it is hidden, the link ID will not be part of the Questionnaire Response item.
By adding link id at the end tag as identifier.
This reverts commit 573aaeb.
- Only use 1 iteration - Use regex to find and match tags - Use index for substitution - Use StringBuilder to avoid creating new String instances when doing substitution (using kotlin replace) - Keep using the while loop, as using forEach will skip a character following a replacement (See line 47 in HtmlPopulator class)
Temporary solution, best way is to use rules engine, but rules in root (patient name) cannot interact with the rules in each list item (file name).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly data capture changes, we probably want to close this, open a new PR in https://github.com/onaio/android-fhir/tree/master/datacapture with the data capture changes, cut a release from that, incorporate that release
IMPORTANT: Where possible all PRs must be linked to a Github issue
Engineer Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guideCode Reviewer Checklist
strings.xmlfile