Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure supervisor contact #3404

Merged
merged 46 commits into from
Sep 5, 2024
Merged

Configure supervisor contact #3404

merged 46 commits into from
Sep 5, 2024

Conversation

sharon2719
Copy link
Contributor

@sharon2719 sharon2719 commented Jul 25, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3391
Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@sharon2719 sharon2719 linked an issue Jul 25, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 65 lines in your changes missing coverage. Please review.

Project coverage is 27.1%. Comparing base (115c4f4) to head (65b79bf).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...rtregister/fhircore/quest/ui/pin/PinLoginScreen.kt 0.0% 23 Missing ⚠️
...artregister/fhircore/quest/ui/login/LoginScreen.kt 0.0% 11 Missing ⚠️
...fhircore/engine/util/extension/StringExtensions.kt 0.0% 7 Missing ⚠️
...tregister/fhircore/quest/ui/login/LoginActivity.kt 0.0% 6 Missing and 1 partial ⚠️
...register/fhircore/quest/ui/login/LoginViewModel.kt 0.0% 6 Missing ⚠️
...martregister/fhircore/quest/ui/pin/PinViewModel.kt 0.0% 6 Missing ⚠️
...register/fhircore/quest/ui/pin/PinLoginActivity.kt 0.0% 3 Missing ⚠️
...fhircore/quest/util/extensions/ConfigExtensions.kt 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3404     +/-   ##
=========================================
- Coverage     27.2%   27.1%   -0.2%     
- Complexity     742     745      +3     
=========================================
  Files          276     275      -1     
  Lines        13811   13946    +135     
  Branches      2504    2527     +23     
=========================================
+ Hits          3764    3780     +16     
- Misses        9540    9644    +104     
- Partials       507     522     +15     
Flag Coverage Δ
engine 64.3% <0.0%> (-0.4%) ⬇️
geowidget 11.5% <ø> (+<0.1%) ⬆️
quest 5.5% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...fhircore/quest/util/extensions/ConfigExtensions.kt 0.0% <0.0%> (ø)
...register/fhircore/quest/ui/pin/PinLoginActivity.kt 5.4% <0.0%> (-3.5%) ⬇️
...register/fhircore/quest/ui/login/LoginViewModel.kt 1.6% <0.0%> (-0.1%) ⬇️
...martregister/fhircore/quest/ui/pin/PinViewModel.kt 5.6% <0.0%> (-1.1%) ⬇️
...fhircore/engine/util/extension/StringExtensions.kt 70.9% <0.0%> (-20.7%) ⬇️
...tregister/fhircore/quest/ui/login/LoginActivity.kt 5.8% <0.0%> (-0.7%) ⬇️
...artregister/fhircore/quest/ui/login/LoginScreen.kt 0.0% <0.0%> (ø)
...rtregister/fhircore/quest/ui/pin/PinLoginScreen.kt 0.0% <0.0%> (ø)

... and 4 files with indirect coverage changes

@SebaMutuku
Copy link
Contributor

@sharon2719 would you mind adding screenshots of the forgotPinDialog and launch dial pad?

Copy link
Member

@pld pld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharon2719
Copy link
Contributor Author

Screencast from 25-07-2024 05:23:10 ALASIRI.webm
Here is the video showing how it works

pld
pld previously approved these changes Jul 28, 2024
@pld pld enabled auto-merge July 28, 2024 01:33
SebaMutuku
SebaMutuku previously approved these changes Jul 29, 2024
@sharon2719 sharon2719 dismissed stale reviews from SebaMutuku and pld via 7b08462 July 29, 2024 14:44
@ellykits ellykits changed the title Change the contact number to be configurable Configure supervisor contact Sep 4, 2024
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
@ellykits ellykits merged commit 3a93d7d into main Sep 5, 2024
4 of 5 checks passed
@ellykits ellykits deleted the customize-contact-info branch September 5, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the contact number under Forgot PIN
5 participants