Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up P2P lib version #3453

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Conversation

Rkareko
Copy link
Contributor

@Rkareko Rkareko commented Aug 19, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes the following issues
Update Google Location Services to 21+
Request for NEARBY_WIFI_DEVICES permission for Android 13 and higher

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@Rkareko Rkareko self-assigned this Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.3%. Comparing base (115c4f4) to head (5f33dc0).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3453   +/-   ##
=======================================
  Coverage     27.2%   27.3%           
- Complexity     742     746    +4     
=======================================
  Files          276     276           
  Lines        13811   13823   +12     
  Branches      2504    2504           
=======================================
+ Hits          3764    3777   +13     
+ Misses        9540    9527   -13     
- Partials       507     519   +12     
Flag Coverage Δ
engine 64.3% <ø> (-0.4%) ⬇️
geowidget 11.4% <ø> (ø)
quest 5.5% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@@ -66,7 +66,7 @@ okhttp = "4.12.0"
okhttp-logging-interceptor = "4.12.0"
orchestrator = "1.5.0"
owasp = "8.2.1"
p2p-lib = "0.6.9-SNAPSHOT"
p2p-lib = "0.6.10-SNAPSHOT"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rkareko Can we do this for the opensrp-0.2.5 branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are already on opensrp-0.2.5 branch

@Rkareko Rkareko enabled auto-merge August 23, 2024 07:08
@ellykits ellykits disabled auto-merge August 27, 2024 07:31
@ellykits ellykits merged commit 3901bd7 into main Aug 27, 2024
5 checks passed
@ellykits ellykits deleted the p2p-fix-location-and-nearby-wifi-devices-perms branch August 27, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants