Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map search bug fixes #3516

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

dubdabasoduba
Copy link
Member

@dubdabasoduba dubdabasoduba commented Sep 23, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3517
Fixes #3518

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

- Updating the behaviour after clearing search bar on the maps
@dubdabasoduba dubdabasoduba self-assigned this Sep 23, 2024
@dubdabasoduba dubdabasoduba added the Bug-fix PR label for bug fix on release notes label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 27.8%. Comparing base (2f8055b) to head (0016007).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...er/fhircore/engine/data/local/DefaultRepository.kt 0.0% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3516     +/-   ##
=========================================
+ Coverage     27.2%   27.8%   +0.6%     
- Complexity     749     756      +7     
=========================================
  Files          275     275             
  Lines        13940   13824    -116     
  Branches      2532    2494     -38     
=========================================
+ Hits          3794    3852     +58     
+ Misses        9622    9437    -185     
- Partials       524     535     +11     
Flag Coverage Δ
geowidget 15.4% <ø> (+2.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rcore/quest/ui/main/components/TopScreenSection.kt 0.0% <ø> (ø)
...er/fhircore/engine/data/local/DefaultRepository.kt 60.5% <0.0%> (-4.6%) ⬇️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug-fix PR label for bug fix on release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite scroll error at the bottom of the screen Refresh map after clearing search text
1 participant