Main | Performance improvements

[dubdabasoduba]

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

• I have written Unit tests for any new feature(s) and edge cases for bug fixes
• I have added any strings visible on UI components to the strings.xml file
• I have updated the CHANGELOG.md file for any notable changes to the codebase
• I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
• I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
• I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

• I have verified Unit tests have been written for any new feature(s) and edge cases
• I have verified any strings visible on UI components are in the strings.xml file
• I have verifed the CHANGELOG.md file has any notable changes to the codebase
• I have verified the solution has been implemented in a configurable and generic way for reuseable components
• I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

[codecov]

Codecov Report

Attention: Patch coverage is 29.06977% with 61 lines in your changes missing coverage. Please review.

Project coverage is 27.2%. Comparing base (6fc15b0) to head (331ec24).
Report is 18 commits behind head on main.

Files with missing lines	Patch %	Lines
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt	15.3%	55 Missing ⚠️
...register/fhircore/engine/datastore/ContentCache.kt	60.0%	3 Missing and 1 partial ⚠️
...er/fhircore/engine/data/local/DefaultRepository.kt	0.0%	1 Missing ⚠️
...re/engine/data/remote/shared/TokenAuthenticator.kt	50.0%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##              main   #3586    +/-   ##
========================================
  Coverage     27.1%   27.2%            
- Complexity     775     784     +9     
========================================
  Files          279     282     +3     
  Lines        14563   14663   +100     
  Branches      2608    2623    +15     
========================================
+ Hits          3957    3994    +37     
- Misses       10065   10125    +60     
- Partials       541     544     +3     

Flag	Coverage Δ
engine	63.7% <70.0%> (-0.1%)	⬇️
geowidget	16.0% <ø> (ø)
quest	5.7% <16.6%> (+<0.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ster/fhircore/engine/task/FhirCarePlanGenerator.kt	78.7% <100.0%> (+0.5%)	⬆️
...hircore/quest/ui/appsetting/AppSettingViewModel.kt	2.2% <ø> (ø)
...tregister/fhircore/quest/ui/login/LoginActivity.kt	7.6% <100.0%> (+1.8%)	⬆️
...er/fhircore/engine/data/local/DefaultRepository.kt	58.9% <0.0%> (-0.1%)	⬇️
...re/engine/data/remote/shared/TokenAuthenticator.kt	74.4% <50.0%> (-0.6%)	⬇️
...register/fhircore/engine/datastore/ContentCache.kt	60.0% <60.0%> (ø)
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt	4.3% <15.3%> (+1.0%)	⬆️

... and 1 file with indirect coverage changes

[pld]

This looks like the main error The automatic loading of test framework implementation dependencies has been deprecated. This is scheduled to be removed in Gradle 9.0. Declare the desired test framework directly on the test suite or explicitly declare the test framework implementation dependencies on the test's runtime classpath. Consult the upgrading guide for further information: https://docs.gradle.org/8.5/userguide/upgrading_version_8.html#test_framework_implementation_dependencies

[LZRS]

This looks like the main error The automatic loading of test framework implementation dependencies has been deprecated. This is scheduled to be removed in Gradle 9.0. Declare the desired test framework directly on the test suite or explicitly declare the test framework implementation dependencies on the test's runtime classpath. Consult the upgrading guide for further information: https://docs.gradle.org/8.5/userguide/upgrading_version_8.html#test_framework_implementation_dependencies

Moving this to be tracked in a separate issue

[ellykits]

Why are we introducing this cache?

[ellykits]

There is this Kotlin library https://github.com/MayakaApps/Kache