Skip to content

Commit

Permalink
upstream: Use curve25519-sha256 kex where possible.
Browse files Browse the repository at this point in the history
Except where we're explicitly testing a different kex, use
curve25519-sha256 since it's faster than the default and supported even
when configured without OpenSSL.  Add a check to ensure that the kex we
intended to test is the one we actually tested. Speeds test up by ~5%.

OpenBSD-Regress-ID: 3b27fcc2ae953cb08fd82a0d3155c498b226d6e0
  • Loading branch information
daztucker committed Aug 21, 2024
1 parent 3eb62b7 commit 25c52f3
Showing 1 changed file with 13 additions and 2 deletions.
15 changes: 13 additions & 2 deletions regress/rekey.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# $OpenBSD: rekey.sh,v 1.26 2024/08/20 12:36:59 dtucker Exp $
# $OpenBSD: rekey.sh,v 1.27 2024/08/21 06:59:08 dtucker Exp $
# Placed in the Public Domain.

tid="rekey"
Expand All @@ -11,6 +11,7 @@ cp $OBJ/sshd_proxy $OBJ/sshd_proxy_bak

echo "Compression no" >> $OBJ/ssh_proxy
echo "RekeyLimit 256k" >> $OBJ/ssh_proxy
echo "KexAlgorithms curve25519-sha256" >> ssh_proxy

# Test rekeying based on data volume only.
# Arguments: rekeylimit, kex method, optional remaining opts are passed to ssh.
Expand All @@ -31,14 +32,24 @@ ssh_data_rekeying()
rm -f ${COPY} ${COPY2} ${LOG}
# Create data file just big enough to reach rekey threshold.
dd if=${DATA} of=${COPY} bs=$_bytes count=1 2>/dev/null
${SSH} <${COPY} $_opts -v \
${SSH} <${COPY} $_opts -vv \
-oRekeyLimit=$_bytes -F $OBJ/ssh_proxy somehost "cat >${COPY2}"
if [ $? -ne 0 ]; then
fail "ssh failed ($@)"
fi
cmp ${COPY} ${COPY2} || fail "corrupted copy ($@)"
n=`grep 'NEWKEYS sent' ${LOG} | wc -l`
n=`expr $n - 1`
case "$_kexopt" in
KexAlgorithms*)
_want=`echo $_kexopt | cut -f2 -d=`
_got=`awk 'BEGIN{FS="[ \r]+"} /kex: algorithm: /{print $4}' \
${LOG} | sort -u`
if [ "$_want" != "$_got" ]; then
fail "expected kex $_want, got $_got"
fi
;;
esac
trace "$n rekeying(s)"
if [ $n -lt 1 ]; then
fail "no rekeying occurred ($@)"
Expand Down

0 comments on commit 25c52f3

Please sign in to comment.