-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (async_)block_until_charm_channel support #619
Add (async_)block_until_charm_channel support #619
Conversation
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
d6c927f
to
f585eaf
Compare
This adds async_block_until_charm_channel and block_until_charm_channel which will initially be used for charm upgrade testing.
f585eaf
to
14c14c0
Compare
This change will be used by the charmed-openstack-tester changes in openstack-charmers/charmed-openstack-tester#123 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice; I really like the use of ro_types
to create the test object that has a .charm_channel
accessor. Very clever!
Sync charm-helpers to pick up fix for openstack_upgrade_available that enables successful payload upgrades. This will need backporting to stable/wallaby. openstack-charmers/zaza#619 Closes-Bug: #2040606 Change-Id: Ib1586a486a7a01023bd59bfa70016481ad5f89dc
* Update charm-swift-storage from branch 'master' to ca420eccbb9e1cd51379b27ac684ef6e94d380e7 - Enable swift payload upgrades for wallaby+ Sync charm-helpers to pick up fix for openstack_upgrade_available that enables successful payload upgrades. This will need backporting to stable/wallaby. openstack-charmers/zaza#619 Closes-Bug: #2040606 Change-Id: Ib1586a486a7a01023bd59bfa70016481ad5f89dc
Sync charm-helpers to pick up fix for openstack_upgrade_available that enables successful payload upgrades. This will need backporting to stable/wallaby. openstack-charmers/zaza#619 Closes-Bug: #2040606 Change-Id: Ib5f446d617c11c9c9046c33335c1099b21b5166e
* Update charm-swift-proxy from branch 'master' to 4ebb43d731da8a048e1ac7cc9fc8b33468cb7e76 - Enable swift payload upgrades for wallaby+ Sync charm-helpers to pick up fix for openstack_upgrade_available that enables successful payload upgrades. This will need backporting to stable/wallaby. openstack-charmers/zaza#619 Closes-Bug: #2040606 Change-Id: Ib5f446d617c11c9c9046c33335c1099b21b5166e
This adds async_block_until_charm_channel and
block_until_charm_channel which will initially be
used for charm upgrade testing.