Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding extra volumes to openstack-exporter deployment #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow adding extra volumes to openstack-exporter deployment #11

wants to merge 1 commit into from

Conversation

Lirt
Copy link

@Lirt Lirt commented Feb 4, 2021

This small change allows consumers to mount arbitrary volumes into openstack-exporter Deployment.

Here are example values to mount CA certificate of someone's company as ConfigMap into the Deployment.

extraVolumes:
- name: company-ca
  configMap:
    name: my-company-ca
    items:
    - key: ca
      path: my-company-ca

extraVolumeMounts:
- mountPath: /etc/ssl/certs/my-company-ca
  name: company-ca
  subPath: my-company-ca

ConfigMap can look like this:

kind: ConfigMap
apiVersion: v1
metadata:
  name: my-company-ca
data:
  ca: |
    -----BEGIN CERTIFICATE-----
    ....
    -----END CERTIFICATE-----

This CaCert can be then used within cloud config cloud.yaml:

clouds:
  default:
    region_name: RegionZero
    auth:
      username: "user"
      password: "pass"
      project_name: "my-project"
      project_domain_name: "project-domain"
      user_domain_name: "user-domain"
      auth_url: "https://keystone.example.com:5000"
    verify: true
    cacert: /etc/ssl/certs/my-company-ca

Signed-off-by: Ondrej Vasko o.vasko@pan-net.eu

Signed-off-by: Ondrej Vasko <o.vasko@pan-net.eu>
@Lirt
Copy link
Author

Lirt commented Feb 7, 2021

Hello @mnaser, please let me know if this change makes sense to you.

It's similar thing as for example velero helm chart supports, to give more space for customization. It's intended mainly for purposes of mounting internal CA file for Openstack cloud (there could be other use-cases however).

@Lirt
Copy link
Author

Lirt commented Feb 15, 2021

@niedbalski Hello, can you please check this PR?

Copy link

@Jonher937 Jonher937 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

matofeder added a commit to SovereignCloudStack/openstack-exporter-helm-charts that referenced this pull request May 14, 2024
credit to the original author: Ondrej Vasko <o.vasko@pan-net.eu>
ref: openstack-exporter#11

Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
matofeder added a commit to SovereignCloudStack/openstack-exporter-helm-charts that referenced this pull request May 14, 2024
credit to the original author: Ondrej Vasko <o.vasko@pan-net.eu>
ref: openstack-exporter#11

Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants