Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build_openstack_packages to support downstream gitlab #2699

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Update build_openstack_packages to support downstream gitlab #2699

merged 1 commit into from
Feb 12, 2025

Conversation

raukadah
Copy link
Contributor

@raukadah raukadah commented Jan 31, 2025 •
edited
Loading

This pr:
* Since downstream gerrit repos is moved to gitlab. Zuul works with gitlab and it clones the gitlab repos in
job workspace. Use the zuul clonned content instead of clonning from gerrit or gitlab. As zuul already checks
out the source code. Let's reuse it for dlrn purpose by updating packages.yml.
* Drop branch creation task as it is no longer needed.
* For RHOS-18, downstream distgit uses rhoso-18 not rhos. It also updates the project.ini to reflect the same.

Note: While running build_openstack_packages in containers using make run_ctx_molecule, we are hitting following error in rpmbuild.log in CI and in local environment.

DEBUG: unshare(67239936) failed, falling back to unshare(131072)
ERROR: Namespace unshare failed.

Based on this bug , By passing --cap-add=SYS_ADMIN fixes the issue.

Signed-off-by: Chandan Kumar (raukadah) raukadah@gmail.com

Related-Jira: https://issues.redhat.com/browse/OSPRH-13660

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 31, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cescgina for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raukadah raukadah marked this pull request as ready for review January 31, 2025 13:23
lewisdenny
lewisdenny requested changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raukadah, could you please add a commit message to explain this change

@raukadah raukadah marked this pull request as draft February 3, 2025 06:06
@raukadah raukadah marked this pull request as ready for review February 3, 2025 06:11
@raukadah
Copy link
Contributor Author

raukadah commented Feb 3, 2025

/hold

@raukadah raukadah force-pushed the fix_downstream branch 6 times, most recently from 4070691 to 798e3bf Compare February 3, 2025 10:48
@raukadah raukadah changed the title [WIP]Use zuul clonned repo instead of pulling from git source Update build_openstack_packages to support downstream gitlab cee Feb 3, 2025
@raukadah
Copy link
Contributor Author

raukadah commented Feb 3, 2025

/hold cancel

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d83f0a1ba98841b6a9dd1214a1e9b5ef

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 35m 27s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 33s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 21m 20s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 08s
❌ cifmw-pod-pre-commit FAILURE in 7m 37s
✔️ ci-framework-openstack-meta-content-provider SUCCESS in 13m 52s
✔️ build-push-container-cifmw-client SUCCESS in 22m 53s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 14m 46s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5934fa9cdc064d5da7b036aca0968a66

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 25m 01s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 10m 06s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 20m 31s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 23s
❌ cifmw-pod-pre-commit FAILURE in 7m 05s
✔️ ci-framework-openstack-meta-content-provider SUCCESS in 14m 27s
✔️ build-push-container-cifmw-client SUCCESS in 18m 16s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 11m 32s

@openshift-ci openshift-ci bot added the lgtm label Feb 11, 2025
@raukadah
Update build_openstack_packages to support downstream gitlab
58baced 
This pr:
* Since downstream gerrit repos is moved to gitlab. Zuul works
  with gitlab and it clones the gitlab repos in job workspace.
  Use the zuul clonned content instead of clonning from gerrit or
  gitlab. As zuul already checks out the source code. Let's reuse it
  for dlrn purpose by updating packages.yml.

* Drop branch creation task as it is no longer needed.

* For RHOS-18, downstream distgit uses rhoso-18 not rhos. It also
  updates the project.ini to reflect the same.

Note: While running build_openstack_packages in containers using
make run_ctx_molecule, we are hitting following error in rpmbuild.log in
CI and in local environment.
```
DEBUG: unshare(67239936) failed, falling back to unshare(131072)
ERROR: Namespace unshare failed.
```
Based on this bug
https://bugzilla.redhat.com/show_bug.cgi?id=1336750#c3,
By passing `--cap-add=SYS_ADMIN` fixes the issue.

Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>

Related-Jira: https://issues.redhat.com/browse/OSPRH-13660
@openshift-ci openshift-ci bot removed the lgtm label Feb 11, 2025
@karelyatin
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 11, 2025
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/78462938d37f4eb8aeb4e8b6771a7dc1

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 34m 51s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 56s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 39s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 42s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 24s
✔️ ci-framework-openstack-meta-content-provider SUCCESS in 13m 48s
✔️ build-push-container-cifmw-client SUCCESS in 23m 56s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 15m 08s

@raukadah
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6c3a72045890400192527d450c169717

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 40s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 26m 56s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 55s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 15s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 43s
✔️ ci-framework-openstack-meta-content-provider SUCCESS in 14m 47s
✔️ build-push-container-cifmw-client SUCCESS in 19m 00s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 15m 15s

@karelyatin
Copy link
Contributor

recheck RETRY_LIMIT

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bce2195e14724cfe8a42f69caa6b053d

❌ openstack-k8s-operators-content-provider FAILURE in 6m 30s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 41s
✔️ cifmw-pod-pre-commit SUCCESS in 11m 26s
✔️ ci-framework-openstack-meta-content-provider SUCCESS in 14m 28s
✔️ build-push-container-cifmw-client SUCCESS in 17m 58s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 13m 17s

@raukadah
Copy link
Contributor Author

recheck

@karelyatin karelyatin dismissed pablintino’s stale review February 12, 2025 06:10

All comments covered, and to unblock the merge

@karelyatin karelyatin merged commit 351e999 into openstack-k8s-operators:main Feb 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanMooney SeanMooney SeanMooney left review comments

@karelyatin karelyatin karelyatin left review comments

@lewisdenny lewisdenny lewisdenny approved these changes

@bshewale bshewale bshewale approved these changes

@evallesp evallesp Awaiting requested review from evallesp

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

@pablintino pablintino Awaiting requested review from pablintino

Assignees

@SeanMooney SeanMooney

@karelyatin karelyatin

Labels
lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@raukadah @karelyatin @lewisdenny @SeanMooney @pablintino @bshewale