Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rhol_crc] add_crc_creds: Fix check for kubeconfig #837

Conversation

elfiesmelfie
Copy link
Contributor

@elfiesmelfie elfiesmelfie commented Nov 22, 2023

The check currently doesn't provide any feedback when the kubeconfig doesn't exist in the expected location.
If the kubeconfig doesn't exist in the expected location, there should be an error. This enhances the user experience by telling them the issue right away.

The error come up here: https://review.rdoproject.org/zuul/build/f77349f5e5cb4fff829e5272f04f5b0b/console#9/0/6/controller

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

The check currently doesn't provide any feedback when the kubeconfig
doesn't exist in the expected location.
If the kubeconfig doesn't exist in the expected location, there should
be an error. This enhances the user experience by telling them the issue
right away.
Copy link
Contributor

openshift-ci bot commented Nov 22, 2023

Hi @elfiesmelfie. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pablintino
Copy link
Collaborator

/ok-to-test
/approve

Copy link
Contributor

openshift-ci bot commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Nov 24, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 27729af into openstack-k8s-operators:main Nov 24, 2023
10 of 11 checks passed
@elfiesmelfie elfiesmelfie deleted the efoley-update-kubeconfig-check branch November 28, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants