Use copy instead of template for disconnected registries.conf #808

bshephar · 2024-11-13T03:46:45Z

This change switches the Ansible module from template to copy for writing the disconnected registries.conf file. Since trying to use src in the template module looks for a path and not content.

Jira: https://issues.redhat.com/browse/OSPRH-11475

rabi

Did we not test it at all? That would have never worked.

bshephar · 2024-11-13T05:18:09Z

Did we not test it at all? That would have never worked.

I checked the container I built to test this in my lab, it used copy and content. It seems I then got distracted by the issues I was having with the openstack-operator side of the change and forgot to update my PR for edpm-ansible. My bad.

slagle · 2024-11-13T12:08:53Z

roles/edpm_podman/tasks/install.yml

-      ansible.builtin.template:
-        src: "{{ edpm_podman_registries_conf }}"
+      ansible.builtin.copy:
+        content: "{{ edpm_podman_registries_conf }}"


this LGTM as a fix.
I missed reviewing the original patch that added the variable. I think we need a way to distinguish between variables that are meant to be set by our code (openstack-operator in this case), and user variables. As it is now, a user has no way of knowing that they shouldn't use this variable themselves, and if they do, it might not even take effect as they intend.

Just looking at the variable, and the description in argument_specs.yml, as I user I would expect I could use this to define the registries.conf content. When in fact, it only works with disconnected, and could also be overwritten by openstack-operator.

I think we should file an issue to clean this sort of thing up across all the code, b/c I'm sure there are other examples.

softwarefactory-project-zuul · 2024-11-14T05:08:18Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a3c1f66025e640edb90591ef160fde2d

bshephar · 2024-11-14T05:26:24Z

Adoption job failed:

❯ curl -s "https://logserver.rdoproject.org/08/808/f7f124df2108cc1d082fb988bca47cc2643a691a/github-check/adoption-standalone-to-crc-ceph-provider/14968bf/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/crs/openstackdataplanedeployments.dataplane.openstack.org/tripleo-cleanup.yaml" | yq '.status.conditions[0]'
lastTransitionTime: "2024-11-14T04:44:26Z"
message: 'Deployment error occurred nodeSet: openstack error: backoff limit reached for execution.name tripleo-cleanup-tripleo-cleanup-openstack execution.namespace openstack execution.condition.message: Job has reached the specified backoff limit'
reason: BackoffLimitExceeded
severity: Error
status: "False"
type: Ready

Seems unrelated:

❯ curl -s "https://logserver.rdoproject.org/08/808/f7f124df2108cc1d082fb988bca47cc2643a691a/github-check/adoption-standalone-to-crc-ceph-provider/14968bf/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/tripleo-cleanup-tripleo-cleanup-openstack-9hphq/logs/tripleo-cleanup-tripleo-cleanup-openstack.log"  | grep -E "failed: \[standalone\]" | tail -n1
failed: [standalone] (item={'failed': False, 'msg': 'Failed to mask the service (tripleo_swift_proxy.service): Failed to mask unit: File /etc/systemd/system/tripleo_swift_proxy.service already exists.', 'invocation': {'module_args': {'name': 'tripleo_swift_proxy.service', 'state': 'stopped', 'enabled': False, 'masked': True, 'daemon_reload': False, 'daemon_reexec': False, 'scope': 'system', 'no_block': False, 'force': None}}, 'changed': False, 'failed_when_result': False, 'item': 'tripleo_swift_proxy.service', 'ansible_loop_var': 'item'}) => {

bshephar · 2024-11-14T05:26:28Z

recheck

softwarefactory-project-zuul · 2024-11-14T07:55:51Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/963a5004082e4b0ebf072fc443cf9b54

bshephar · 2024-11-15T04:07:03Z

Same thing on recheck. There's something that needs fixing in the adoption job I guess:

❯ curl -s "https://logserver.rdoproject.org/08/808/f7f124df2108cc1d082fb988bca47cc2643a691a/github-check/adoption-standalone-to-crc-ceph-provider/d2e0237/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/tripleo-cleanup-tripleo-cleanup-openstack-974q9/logs/tripleo-cleanup-tripleo-cleanup-openstack.log" | grep -E "failed: \[standalone\]" | tail -n1
failed: [standalone] (item={'failed': False, 'msg': 'Failed to mask the service (tripleo_swift_proxy.service): Failed to mask unit: File /etc/systemd/system/tripleo_swift_proxy.service already exists.', 'invocation': {'module_args': {'name': 'tripleo_swift_proxy.service', 'state': 'stopped', 'enabled': False, 'masked': True, 'daemon_reload': False, 'daemon_reexec': False, 'scope': 'system', 'no_block': False, 'force': None}}, 'changed': False, 'failed_when_result': False, 'item': 'tripleo_swift_proxy.service', 'ansible_loop_var': 'item'}) => {

rabi · 2024-11-15T05:11:26Z

Same thing on recheck. There's something that needs fixing in the adoption job I guess:

❯ curl -s "https://logserver.rdoproject.org/08/808/f7f124df2108cc1d082fb988bca47cc2643a691a/github-check/adoption-standalone-to-crc-ceph-provider/d2e0237/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/tripleo-cleanup-tripleo-cleanup-openstack-974q9/logs/tripleo-cleanup-tripleo-cleanup-openstack.log" | grep -E "failed: \[standalone\]" | tail -n1
failed: [standalone] (item={'failed': False, 'msg': 'Failed to mask the service (tripleo_swift_proxy.service): Failed to mask unit: File /etc/systemd/system/tripleo_swift_proxy.service already exists.', 'invocation': {'module_args': {'name': 'tripleo_swift_proxy.service', 'state': 'stopped', 'enabled': False, 'masked': True, 'daemon_reload': False, 'daemon_reexec': False, 'scope': 'system', 'no_block': False, 'force': None}}, 'changed': False, 'failed_when_result': False, 'item': 'tripleo_swift_proxy.service', 'ansible_loop_var': 'item'}) => {

Maybe #816 would fix it. This showed up after #804 I guess.

softwarefactory-project-zuul · 2024-11-16T03:10:14Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5df7a185dc1445f49ee8cb4c7251ac4f

This change switches the Ansible module from template to copy for writing the disconnected registries.conf file. Since trying to use `src` in the `template` module looks for a path and not content. Signed-off-by: Brendan Shephard <bshephar@redhat.com>

openshift-ci · 2024-11-18T22:42:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, rabi, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [bshephar,rabi,slagle]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bshephar · 2024-12-02T12:57:14Z

/cherry-pick 18.0-fr1

openshift-cherrypick-robot · 2024-12-02T12:57:52Z

@bshephar: new pull request created: #833

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot requested review from frenzyfriday and olliewalsh November 13, 2024 03:46

openshift-ci bot added the approved label Nov 13, 2024

rabi approved these changes Nov 13, 2024

View reviewed changes

openshift-ci bot assigned rabi Nov 13, 2024

openshift-ci bot added the lgtm label Nov 13, 2024

slagle approved these changes Nov 13, 2024

View reviewed changes

openshift-ci bot assigned slagle Nov 13, 2024

bshephar force-pushed the write-registries-conf branch from 0fffc77 to f7f124d Compare November 14, 2024 02:29

openshift-ci bot removed the lgtm label Nov 14, 2024

bshephar mentioned this pull request Nov 15, 2024

Disconnected molecule #812

Merged

bshephar force-pushed the write-registries-conf branch from f7f124d to fbd3941 Compare November 15, 2024 23:06

bshephar force-pushed the write-registries-conf branch from fbd3941 to a4ac54c Compare November 17, 2024 23:56

slagle approved these changes Nov 18, 2024

View reviewed changes

openshift-ci bot added the lgtm label Nov 18, 2024

openshift-merge-bot bot merged commit 06d9702 into openstack-k8s-operators:main Nov 20, 2024
35 checks passed

openshift-cherrypick-robot mentioned this pull request Dec 2, 2024

[18.0-fr1] Use copy instead of template for disconnected registries.conf #833

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use copy instead of template for disconnected registries.conf #808

Use copy instead of template for disconnected registries.conf #808

bshephar commented Nov 13, 2024 •

edited

Loading

rabi left a comment

bshephar commented Nov 13, 2024

slagle Nov 13, 2024

softwarefactory-project-zuul bot commented Nov 14, 2024

bshephar commented Nov 14, 2024

bshephar commented Nov 14, 2024

softwarefactory-project-zuul bot commented Nov 14, 2024

bshephar commented Nov 15, 2024

rabi commented Nov 15, 2024

softwarefactory-project-zuul bot commented Nov 16, 2024

openshift-ci bot commented Nov 18, 2024

bshephar commented Dec 2, 2024

openshift-cherrypick-robot commented Dec 2, 2024

Use copy instead of template for disconnected registries.conf #808

Use copy instead of template for disconnected registries.conf #808

Conversation

bshephar commented Nov 13, 2024 • edited Loading

rabi left a comment

Choose a reason for hiding this comment

bshephar commented Nov 13, 2024

slagle Nov 13, 2024

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Nov 14, 2024

bshephar commented Nov 14, 2024

bshephar commented Nov 14, 2024

softwarefactory-project-zuul bot commented Nov 14, 2024

bshephar commented Nov 15, 2024

rabi commented Nov 15, 2024

softwarefactory-project-zuul bot commented Nov 16, 2024

openshift-ci bot commented Nov 18, 2024

bshephar commented Dec 2, 2024

openshift-cherrypick-robot commented Dec 2, 2024

bshephar commented Nov 13, 2024 •

edited

Loading