Drop the default containerImage parameter and use VAR #335
Conversation
lmiccini
force-pushed
the
drop_default_iha_image
branch
from
56df2d1 to
502a989
Compare
Let's not use the hardcoded default but rely on the RELATED_* vars. Jira: OSPRH-13093
|
/test precommit-check |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a1302c8b1bbf4305b8ee9357548d0268 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 10m 21s |
|
recheck |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, lmiccini, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit d7bb082
into
openstack-k8s-operators:main
|
/cherrypick 18.0-fr1 |
|
@lmiccini: new pull request created: #336 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick 18.0-fr1 |
|
@lmiccini: new pull request could not be created: failed to create pull request against #18.0-fr1 from head openshift-cherrypick-robot:cherry-pick-335-to-18.0-fr1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-335-to-18.0-fr1."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hard coding the containerImage value is problematic b/c our build system would not override the value set in the crd automatically, so the variable ends up being set to the wrong image in the crd definition.
Let's try using RELATED_* vars (set by the infra-operator itself, because we can't have two vars using the same value, see openstack-k8s-operators/openstack-operator#1150).
Jira: OSPRH-13093