Validate spec.storageRequest via validation webhook #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Jun 24, 2024
Notify the enduser if the configured DB storageRequest is too low for production use. It is not blocking to allow lower settings for test/ci systems. The output would be like: $ oc apply -n openstack -f core_v1beta1_openstackcontrolplane_galera_network_isolation_3replicas.yaml Warning: Note! spec.galera.template[openstack-cell1].storageRequest: 1G is not appropriate for production! For production use at least 5G! Warning: Note! spec.galera.template[openstack].storageRequest: 500M is not appropriate for production! For production use at least 5G! Depends-On: openstack-k8s-operators/lib-common#522 Depends-On: openstack-k8s-operators/mariadb-operator#234 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
force-pushed
the
storage_request_webhook
branch
from
6443895 to
7f344bb
Compare
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Jun 24, 2024
Notify the enduser if the configured DB storageRequest is too low for production use. It is not blocking to allow lower settings for test/ci systems. The output would be like: $ oc apply -n openstack -f core_v1beta1_openstackcontrolplane_galera_network_isolation_3replicas.yaml Warning: spec.galera.template[openstack-cell1].storageRequest: 1G is not appropriate for production! For production use at least 5G! Warning: spec.galera.template[openstack].storageRequest: 500M is not appropriate for production! For production use at least 5G! Depends-On: openstack-k8s-operators/lib-common#522 Depends-On: openstack-k8s-operators/mariadb-operator#234 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Notify the enduser if the configured DB storageRequest is too low for production use. It is not blocking to allow lower settings for test/ci systems. The output would be like: $ oc apply -n openstack -f core_v1beta1_openstackcontrolplane_galera_network_isolation_3replicas.yaml Warning: spec.galera.template[openstack-cell1].storageRequest: 1G is not appropriate for production! For production use at least 5G! Warning: spec.galera.template[openstack].storageRequest: 500M is not appropriate for production! For production use at least 5G! Depends-On: openstack-k8s-operators/lib-common#522 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
force-pushed
the
storage_request_webhook
branch
from
7f344bb to
954593f
Compare
|
New changes are detected. LGTM label has been removed. |
|
/lgtm |
openshift-merge-bot
bot
merged commit 414cc98
into
openstack-k8s-operators:main
6 checks passed
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Jun 24, 2024
Notify the enduser if the configured DB storageRequest is too low for production use. It is not blocking to allow lower settings for test/ci systems. The output would be like: $ oc apply -n openstack -f core_v1beta1_openstackcontrolplane_galera_network_isolation_3replicas.yaml Warning: spec.galera.template[openstack-cell1].storageRequest: 1G is not appropriate for production! For production use at least 5G! Warning: spec.galera.template[openstack].storageRequest: 500M is not appropriate for production! For production use at least 5G! Depends-On: openstack-k8s-operators/lib-common#522 Depends-On: openstack-k8s-operators/mariadb-operator#234 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Jun 24, 2024
Notify the enduser if the configured DB storageRequest is too low for production use. It is not blocking to allow lower settings for test/ci systems. The output would be like: $ oc apply -n openstack -f core_v1beta1_openstackcontrolplane_galera_network_isolation_3replicas.yaml Warning: spec.galera.template[openstack-cell1].storageRequest: 1G is not appropriate for production! For production use at least 5G! Warning: spec.galera.template[openstack].storageRequest: 500M is not appropriate for production! For production use at least 5G! Depends-On: openstack-k8s-operators/lib-common#522 Depends-On: openstack-k8s-operators/mariadb-operator#234 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notify the enduser if the configured DB storageRequest is too low for production use. It is not blocking to allow lower settings for test/ci systems. The output would be like:
Depends-On: openstack-k8s-operators/lib-common#522