Grow volumes on hardened overcloud-full image #844
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olliewalsh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
olliewalsh
force-pushed
the
hardened
branch
2 times, most recently
from
69ae5b8 to
e7df9b6
Compare
olliewalsh
force-pushed
the
hardened
branch
4 times, most recently
from
a076269 to
c021def
Compare
olliewalsh
force-pushed
the
hardened
branch
10 times, most recently
from
153d1c7 to
e6c629f
Compare
|
|
||
| // GetRoleGrowvolsArgs - return default growvols args for the given tripleo role name | ||
| func GetRoleGrowvolsArgs(role string) []string { | ||
| if role == "Controller" { |
There was a problem hiding this comment.
should this be a regexp to match all the different default Controller* roles?
There was a problem hiding this comment.
this is copied from the playbook used in a traditional director deployment so I've kept is consistent
| @@ -15,3 +15,6 @@ chpasswd: | |||
| bootcmd: | |||
| # fix BLS entries | |||
| - set -x; if [ -e /boot/loader/entries/ffffffffffffffffffffffffffffffff-* ]; then MACHINEID=$(cat /etc/machine-id) && rename "ffffffffffffffffffffffffffffffff" "$MACHINEID" /boot/loader/entries/ffffffffffffffffffffffffffffffff-* ; fi | |||
| runcmd: | |||
| # grow volumes on hardened image if command exists | |||
| - set -x; if [ -e /usr/local/sbin/growvols ]; then /usr/local/sbin/growvols --yes {{ range .GrowvolsArgs}}{{.|trim}} {{end}}; fi | |||
There was a problem hiding this comment.
from where is /usr/local/sbin/growvols coming? is it part of the overcloud image?
There was a problem hiding this comment.
only the overcloud images with lvm. Logic comes from https://github.com/openstack/tripleo-ansible/blob/stable/wallaby/tripleo_ansible/playbooks/cli-overcloud-node-growvols.yaml which is run on all nodes when deploying with python-tripleoclient
There was a problem hiding this comment.
/lgtm
Even if the underlying mechanism switches from cloud-init to ansible in the future, the exposed GrowvolsArgs interface won't change, so this is fine.
The only downside of cloud-init is if they provide custom invalid GrowvolsArgs, and they may not notice until the deployment fails with a full (tiny) disk. I don't think this will be a huge issue in practice
No description provided.