[docs] Change namespace to openstack-test-operator #265
Conversation
Recently we changed the test-operator from cluster scoped to namespace scoped operator. This patch ensures that we reflect this change in the test-operator documentation.
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lpiwowar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
| @@ -152,14 +189,14 @@ Please make sure that you follow the order of the steps: | |||
|
|
|||
| .. code-block:: bash | |||
|
|
|||
| oc delete operator/test-operator.openstack-operators | |||
| oc delete operator/test-operator.openstack-test-operator | |||
|
|
|||
| 7. Check that there are no test-operator related resources hanging. This step | |||
| is not required. | |||
|
|
|||
| .. code-block:: bash | |||
|
|
|||
There was a problem hiding this comment.
The deletion of OperatorGroup is missing, so after following the steps it's not a completely clean environment.
oc delete operatorgroup.operators.coreos.com/test-operator -n openstack-test-operator This worked for deletion, but maybe there is better way to do it 😄
|
|
||
| .. code-block:: bash | ||
|
|
||
| oc new-project openstack-test-operator |
There was a problem hiding this comment.
The project is created, but never deleted. I am not sure if that is intentional. If yes, please ignore this comment.
| @@ -76,6 +101,18 @@ project. | |||
| test-operator-controller-manager-6c9994847c-6jwn5 2/2 Running 0 20s | |||
There was a problem hiding this comment.
This line need to be changed into oc get pods -n openstack-test-operator, that is where te controller manager is newly created.
| @@ -50,24 +76,23 @@ project. | |||
| kind: Subscription | |||
| metadata: | |||
| name: test-operator | |||
| namespace: openstack-operators | |||
| namespace: openstack-test-operator | |||
| spec: | |||
| name: test-operator | |||
| source: openstack-operator-index | |||
| sourceNamespace: openstack-operators | |||
There was a problem hiding this comment.
I think that the sourceNamespace: openstack-operators should also be changed into opentack-test-operator. Or at least that is how my testing yaml for this patch worked correctly.
|
|
||
| 5. Remove test-operator related installplan (replace :code:`XXXXX` with value obtained | ||
| with the first command :code:`oc get installplans`) | ||
|
|
||
| .. code-block:: bash | ||
|
|
||
| oc get installplans -n openstack-operators | grep "test-operator" | ||
| oc get installplans -n openstack-test-operator | grep "test-operator" |
There was a problem hiding this comment.
When I test the patch, I didn't find any installplans in openstack-test-operator namespace. Don't know why that is, maybe it was fault in my testing, but I still wanted to ask about this.
|
Thank you @kstrenkova for the review!:) I'm closing the PR because we agreed not to switch the test-operator to a namespace scoped operator. The discussion can be found here -> #264 |
Recently we changed the test-operator from cluster scoped to namespace
scoped operator. This patch ensures that we reflect this change in the
test-operator documentation.