Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use opendev master content in meta content provider #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raukadah
Copy link
Contributor

@raukadah raukadah commented Jan 16, 2025

In order to test opendev watcher patches, we need to add build opendev watcher project from master.

Depends-On: https://review.opendev.org/c/openstack/watcher/+/938893

Depends-On: openstack-k8s-operators/ci-framework#2658

@openshift-ci openshift-ci bot requested review from olliewalsh and viroel January 16, 2025 08:23
Copy link

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from raukadah. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1730a260e8344041aca6f62018345698

✔️ openstack-meta-content-provider-master SUCCESS in 54m 56s
watcher-operator-validation-master RETRY_LIMIT in 0s
✔️ noop SUCCESS in 0s
watcher-operator-validation RETRY_LIMIT in 2s
watcher-operator-kuttl RETRY_LIMIT in 2s

@raukadah
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f87171ca6a324ee6af825ea0ba59de9b

✔️ openstack-meta-content-provider-master SUCCESS in 2h 15m 49s
✔️ watcher-operator-validation-master SUCCESS in 1h 21m 15s
✔️ noop SUCCESS in 0s
watcher-operator-validation FAILURE in 18m 35s
watcher-operator-kuttl RETRY_LIMIT in 15m 26s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/be9fe455e2d7496ababc7079b8311b8c

✔️ openstack-meta-content-provider-master SUCCESS in 2h 18m 44s
✔️ watcher-operator-validation-master SUCCESS in 1h 21m 33s
✔️ noop SUCCESS in 0s
✔️ watcher-operator-validation SUCCESS in 1h 21m 33s
watcher-operator-kuttl RETRY_LIMIT in 16m 14s

@raukadah raukadah force-pushed the zuul_job_main branch 2 times, most recently from b4b9fb6 to 4b637fb Compare January 20, 2025 06:15
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2658 is needed.

@raukadah
Copy link
Contributor Author

recheck

# Override zuul meta content provider provided content_provider_dlrn_md5_hash
# var. As returned dlrn md5 hash comes from master release but job is using
# antelope content.
content_provider_dlrn_md5_hash: ''
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(trying to understand)... is an alternative to doing this (false update_containers and hash set to '') perhaps to have a -antelope content provider instead of a master one here? or we don't want/need -antelope content provider?

Copy link
Contributor Author

@raukadah raukadah Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal here is to always test openstack watcher content from master branch in master and antelope based EDPM job. watcher-operator-validation job is deploying using antelope content and watcher-operator should use openstack services container from meta content provider master.

That's why we donot want to use antelope content provider.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks its a bit clearer now and i also read the commit message but theres a few things going on here.

i'm still not clear why we need the content provider at all then in those cases we don't use the built containers from it.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/524b3ac564c747afb547af3e7cc3336d

✔️ openstack-meta-content-provider-master SUCCESS in 50m 42s
watcher-operator-validation-master RETRY_LIMIT in 0s
✔️ noop SUCCESS in 0s
watcher-operator-validation RETRY_LIMIT in 0s
watcher-operator-kuttl RETRY_LIMIT in 0s

@raukadah
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6425b0194e3343179c9ece4b28dcde08

✔️ openstack-meta-content-provider-master SUCCESS in 53m 56s
watcher-operator-validation-master RETRY_LIMIT in 0s
✔️ noop SUCCESS in 0s
watcher-operator-validation RETRY_LIMIT in 0s
watcher-operator-kuttl RETRY_LIMIT in 2s

In order to test opendev watcher master content in CI job, this pr
adds following thigs:
* opendev-master-watcher-operator-pipeline project template which
  will run meta content provider from master and then Deploy EDPM
  job watcher-operator-validation-master from mastter content.

* It changes the existing job watcher-operator-validation (still
  deploying the antelope content) with update_containers: false to avoid
  using meta content provider containers.

* It also updates the existing watcher-operator-validation and watcher-operator-kuttl
  job to use openstack-meta-content-provider-master as a job
  dependencies.

Depends-On: https://review.opendev.org/c/openstack/watcher/+/938893

Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2658 is needed.

parent: podified-multinode-edpm-deployment-crc-2comp
dependencies: ["openstack-meta-content-provider"]
dependencies: ["openstack-meta-content-provider-master"]
Copy link

@marios marios Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have the dependency at all then if we aren't going to use the built containers. do we need it for something else?

[edit]: maybe repos?
[edit][edit]: ah... operators https://github.com/openstack-k8s-operators/ci-framework/blob/affcd2a89dd04f6f5d0f6e64ddaf7b16b254ef10/roles/reproducer/templates/content-provider.yml.j2#L84

# Override zuul meta content provider provided content_provider_dlrn_md5_hash
# var. As returned dlrn md5 hash comes from master release but job is using
# antelope content.
content_provider_dlrn_md5_hash: ''
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks its a bit clearer now and i also read the commit message but theres a few things going on here.

i'm still not clear why we need the content provider at all then in those cases we don't use the built containers from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants