-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use opendev master content in meta content provider #39
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
378b1f4
to
8398c75
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1730a260e8344041aca6f62018345698 ✔️ openstack-meta-content-provider-master SUCCESS in 54m 56s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f87171ca6a324ee6af825ea0ba59de9b ✔️ openstack-meta-content-provider-master SUCCESS in 2h 15m 49s |
8398c75
to
8fab0d4
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/be9fe455e2d7496ababc7079b8311b8c ✔️ openstack-meta-content-provider-master SUCCESS in 2h 18m 44s |
b4b9fb6
to
4b637fb
Compare
This change depends on a change that failed to merge. Change openstack-k8s-operators/ci-framework#2658 is needed. |
recheck |
# Override zuul meta content provider provided content_provider_dlrn_md5_hash | ||
# var. As returned dlrn md5 hash comes from master release but job is using | ||
# antelope content. | ||
content_provider_dlrn_md5_hash: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(trying to understand)... is an alternative to doing this (false update_containers and hash set to '') perhaps to have a -antelope content provider instead of a master one here? or we don't want/need -antelope content provider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal here is to always test openstack watcher content from master branch in master and antelope based EDPM job. watcher-operator-validation job is deploying using antelope content and watcher-operator should use openstack services container from meta content provider master.
That's why we donot want to use antelope content provider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok thanks its a bit clearer now and i also read the commit message but theres a few things going on here.
i'm still not clear why we need the content provider at all then in those cases we don't use the built containers from it.
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/524b3ac564c747afb547af3e7cc3336d ✔️ openstack-meta-content-provider-master SUCCESS in 50m 42s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6425b0194e3343179c9ece4b28dcde08 ✔️ openstack-meta-content-provider-master SUCCESS in 53m 56s |
In order to test opendev watcher master content in CI job, this pr adds following thigs: * opendev-master-watcher-operator-pipeline project template which will run meta content provider from master and then Deploy EDPM job watcher-operator-validation-master from mastter content. * It changes the existing job watcher-operator-validation (still deploying the antelope content) with update_containers: false to avoid using meta content provider containers. * It also updates the existing watcher-operator-validation and watcher-operator-kuttl job to use openstack-meta-content-provider-master as a job dependencies. Depends-On: https://review.opendev.org/c/openstack/watcher/+/938893 Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
4b637fb
to
427418e
Compare
This change depends on a change that failed to merge. Change openstack-k8s-operators/ci-framework#2658 is needed. |
parent: podified-multinode-edpm-deployment-crc-2comp | ||
dependencies: ["openstack-meta-content-provider"] | ||
dependencies: ["openstack-meta-content-provider-master"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why have the dependency at all then if we aren't going to use the built containers. do we need it for something else?
[edit]: maybe repos?
[edit][edit]: ah... operators https://github.com/openstack-k8s-operators/ci-framework/blob/affcd2a89dd04f6f5d0f6e64ddaf7b16b254ef10/roles/reproducer/templates/content-provider.yml.j2#L84
# Override zuul meta content provider provided content_provider_dlrn_md5_hash | ||
# var. As returned dlrn md5 hash comes from master release but job is using | ||
# antelope content. | ||
content_provider_dlrn_md5_hash: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok thanks its a bit clearer now and i also read the commit message but theres a few things going on here.
i'm still not clear why we need the content provider at all then in those cases we don't use the built containers from it.
In order to test opendev watcher patches, we need to add build opendev watcher project from master.
Depends-On: https://review.opendev.org/c/openstack/watcher/+/938893
Depends-On: openstack-k8s-operators/ci-framework#2658