Unlimited component updates #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jomcarvajal
requested changes
Sep 22, 2025
src/components/CompletionStatus.tsx
Outdated
| gap: 1rem; | ||
| button { | ||
| min-width: 100px; |
There was a problem hiding this comment.
Can we keep it as rem and not px ?
There was a problem hiding this comment.
After some more thought. I decided to remove the min-width and let the button width hug the text size. it's more consistent with the new Figma designs.
There was a problem hiding this comment.
I also made a slight change to the const buttonText logic because I missed an edge case earlier where the number of completed is 0 and the handle retry is passed in.
src/components/CompletionStatus.tsx
Outdated
| transition: background-color 0.2s ease; | ||
| &:hover { | ||
| background-color: #f5f5f5 !important; |
There was a problem hiding this comment.
We count with colors.palette.neutralBright = #f5f5f5
Same for:
pale = #D5D5D5white = #ffffffblack = #000000
There was a problem hiding this comment.
Good call. 👍 Updated the colors.
jomcarvajal
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/CORE-906