CORE-1287: Port remaining book details page modules from JS to TS #2786

OpenStaxClaude · 2025-10-09T19:21:14Z

Summary

Converted all remaining JavaScript files in src/app/pages/details directory to TypeScript as requested in CORE-1287.

Files Converted

Desktop view modules:

desktop-view.js → desktop-view.tsx
details-tab.js → details-tab.tsx
videos-tab.js → videos-tab.tsx
partners.js → partners.tsx
import-instructor-resource-tab.js → import-instructor-resource-tab.ts
import-student-resource-tab.js → import-student-resource-tab.ts

Phone view modules:

phone-view.js → phone-view.tsx
details-pane.js → details-pane.tsx
student-resources-pane.js → student-resources-pane.tsx
instructor-resources-pane.js → instructor-resources-pane.tsx

Guidelines Followed

All conversions adhere to the TypeScript best practices specified in the ticket:

✅ Avoided using any type
✅ Preferred type to interface
✅ Relied on type inference rather than explicit typing where possible
✅ Used inline type definitions for function parameters
✅ Kept line lengths to under 120 characters

Changes Made

Added proper TypeScript type annotations for all function parameters and return types
Imported types from existing TypeScript files (context.tsx, resource-box-utils.tsx, etc.)
Defined inline types for component props following the project's pattern
Maintained all existing functionality - this is a pure type conversion with no behavioral changes

Test Plan

Verify the application builds successfully
Test desktop view navigation between tabs (Book details, Instructor resources, Student resources, Videos)
Test phone view accordion functionality
Verify resource boxes display correctly on both desktop and mobile
Test partner cards display and navigation
Verify Polish language book pages render correctly

🤖 Generated with Claude Code

RoyEJohnson · 2025-10-15T21:26:49Z

src/app/pages/details/desktop-view/desktop-view.js

The first commit shows the JS->TS changes, and there are a few more changes in the 2nd commit.

RoyEJohnson · 2025-10-15T21:47:37Z

src/app/pages/details/desktop-view/videos-tab/videos-tab.js

Small file, so the changes were too much to show as changes.

RoyEJohnson · 2025-10-15T21:50:05Z

src/app/pages/details/phone-view/instructor-resources-pane/instructor-resources-pane.js

Changes are shown in the individual commits, but there are changes in each of the commits.

RoyEJohnson · 2025-10-15T21:56:13Z

src/app/pages/details/phone-view/phone-view.js

Even the first commit shows it as a delete-and-create. Sorry. :(

RoyEJohnson · 2025-10-15T21:57:45Z

src/app/pages/details/phone-view/student-resources-pane/student-resources-pane.js

Again, even the first commit has it as delete-and-create (the first commit was pretty much just Claude doing the types)

Converted all remaining JavaScript files in src/app/pages/details to TypeScript: Desktop view modules: - desktop-view.js → desktop-view.tsx - details-tab.js → details-tab.tsx - videos-tab.js → videos-tab.tsx - partners.js → partners.tsx - import-*.js → import-*.ts Phone view modules: - phone-view.js → phone-view.tsx - details-pane.js → details-pane.tsx - student-resources-pane.js → student-resources-pane.tsx - instructor-resources-pane.js → instructor-resources-pane.tsx All conversions follow TypeScript best practices: - Avoided using 'any' type - Preferred 'type' to 'interface' - Used type inference where possible - Inline type definitions for function parameters - Line lengths kept under 120 characters 🤖 Generated with [Claude Code](https://claude.com/claude-code) Port remaining book details page modules from JS to TS Converted all remaining JavaScript files in src/app/pages/details to TypeScript: Desktop view modules: - desktop-view.js → desktop-view.tsx - details-tab.js → details-tab.tsx - videos-tab.js → videos-tab.tsx - partners.js → partners.tsx - import-*.js → import-*.ts Phone view modules: - phone-view.js → phone-view.tsx - details-pane.js → details-pane.tsx - student-resources-pane.js → student-resources-pane.tsx - instructor-resources-pane.js → instructor-resources-pane.tsx All conversions follow TypeScript best practices: - Avoided using 'any' type - Preferred 'type' to 'interface' - Used type inference where possible - Inline type definitions for function parameters - Line lengths kept under 120 characters 🤖 Generated with [Claude Code](https://claude.com/claude-code) Revert to JS (loaders) Co-Authored-By: Claude <noreply@anthropic.com>

jivey

Left some minor comments about types

jivey · 2025-10-22T23:45:38Z

src/app/pages/details/context.ts

    freeStuffStudent: StuffContent;
    freeStuffInstructor: StuffContent;
-    videos: VideoContent[];
+    videos: [VideoContent[]] | never[];


This type seems odd, but maybe only because the CMS data shape is odd?

jivey · 2025-10-22T23:50:00Z

src/app/pages/details/common/get-this-title-files/options.tsx

-        <Option condition={model.cheggLink}>
-            <a href={model.cheggLink} data-track="Chegg Reader">
+        <Option condition={model.cheggLink ?? false}>
+            <a href={model.cheggLink as string} data-track="Chegg Reader">


The type for this property seems confusing - it could be null, but not here? Do we need an assertString helper?

jivey · 2025-10-22T23:55:00Z

src/app/pages/details/common/get-this-title-files/options.tsx

                    link={webviewLink}
                    variant="View online"
-                    warning={model.contentWarningText}
+                    warning={model.contentWarningText ?? undefined}


Not a big deal but I wonder if it would be nice to align the component types to the model so we don't have to do this

RoyEJohnson force-pushed the CORE-1287-port-js-to-ts branch 2 times, most recently from 65d1634 to 584cdf5 Compare October 15, 2025 19:31

RoyEJohnson self-assigned this Oct 15, 2025

RoyEJohnson requested a review from jivey October 15, 2025 20:39

RoyEJohnson force-pushed the CORE-1287-port-js-to-ts branch 2 times, most recently from 94c0dff to 852f593 Compare October 15, 2025 21:22

RoyEJohnson reviewed Oct 15, 2025

View reviewed changes

RoyEJohnson force-pushed the CORE-1287-port-js-to-ts branch from 852f593 to 2e6d867 Compare October 15, 2025 21:45

RoyEJohnson reviewed Oct 15, 2025

View reviewed changes

src/app/pages/details/desktop-view/videos-tab/videos-tab.js

Copy link

Contributor

RoyEJohnson Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small file, so the changes were too much to show as changes.

RoyEJohnson reviewed Oct 15, 2025

View reviewed changes

src/app/pages/details/phone-view/phone-view.js

Copy link

Contributor

RoyEJohnson Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even the first commit shows it as a delete-and-create. Sorry. :(

RoyEJohnson reviewed Oct 15, 2025

View reviewed changes

OpenStaxClaude and others added 3 commits October 16, 2025 10:28

Lint clean

a73f87b

Test coverage

f0ec3e6

RoyEJohnson force-pushed the CORE-1287-port-js-to-ts branch from 2e6d867 to f0ec3e6 Compare October 16, 2025 15:28

jivey approved these changes Oct 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CORE-1287: Port remaining book details page modules from JS to TS #2786

CORE-1287: Port remaining book details page modules from JS to TS #2786

Uh oh!

OpenStaxClaude commented Oct 9, 2025 •

edited by atlassian bot

Loading

Uh oh!

RoyEJohnson Oct 15, 2025

Uh oh!

RoyEJohnson Oct 15, 2025

Uh oh!

RoyEJohnson Oct 15, 2025

Uh oh!

RoyEJohnson Oct 15, 2025

Uh oh!

RoyEJohnson Oct 15, 2025

Uh oh!

jivey left a comment

Uh oh!

jivey Oct 22, 2025

Uh oh!

jivey Oct 22, 2025

Uh oh!

jivey Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CORE-1287: Port remaining book details page modules from JS to TS #2786

Are you sure you want to change the base?

CORE-1287: Port remaining book details page modules from JS to TS #2786

Uh oh!

Conversation

OpenStaxClaude commented Oct 9, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Files Converted

Guidelines Followed

Changes Made

Test Plan

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jivey left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

OpenStaxClaude commented Oct 9, 2025 •

edited by atlassian bot

Loading