no-conflict version of shared component styles #18
Conversation
| } | ||
| // The following are usually overlays on other icons | ||
| .icon-correct { .x-icon-bg(correct); } | ||
| .icon-incorrect { .x-icon-bg(incorrect); } |
There was a problem hiding this comment.
I think this is fine for now, however a thought occurs to me.
Since react-components is shared between projects, it's non-optimal that Tutor has the icon definitions for ConceptCoach and vice-versa.
Perhaps we should make a mixin that the client app could call that would auto generate all these definitions. Something like: @openstax-icons( feedback, exercise, homework, event, end, ... );
The actual mixin is left was an exercise for the reader :) It sucks that it's so difficult to loop in less but http://stackoverflow.com/questions/26585733/less-mixin-how-to-loop-through-passed-in-arguments has examples.
|
Overall makes sense and looks good. we can chat about the |
no-conflict version of shared component styles
|
Keeping as-is and discussing |
No description provided.