Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration is not saved if the only change is enabling one extension plugin #1180

Closed
user202729 opened this issue Dec 20, 2020 · 2 comments · Fixed by #1230
Closed

Configuration is not saved if the only change is enabling one extension plugin #1180

user202729 opened this issue Dec 20, 2020 · 2 comments · Fixed by #1230
Assignees
Milestone

Comments

@user202729
Copy link
Member

Summary

See title.

Reproducing

  • Open Plover
  • find some way to install any extension plugin
  • go to Plover configuration to enable it (by clicking the check box, obviously)
  • click "Ok" in the configuration window
  • exit Plover (control+Q)
  • reopen Plover. Observe that the plugin is still disabled.

Plover Version

Latest git master at the present.

System

Arch GNU/Linux (but this should be system-independent), run from source.

@benoit-pierre
Copy link
Member

Is that still an issue?

@user202729
Copy link
Member Author

Yes.

It does happen with the qt GUI, but does not happen with the console ui.

(haven't got the time to debug the issue, but a guess is that some configuration function returns the mutable internal structure, then it cannot detect if it has been mutated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants