gui_qt/config: fix configuring extension plugins #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't mutate the original configuration set, or changes won't be saved.
benoit-pierre
force-pushed
the
fix_extension_plugins_gui_config
branch
from
e4e81e0 to
0051cce
Compare
|
Good job tracking the bug down... But would it be a potential trap for new GUI plugin developers? |
|
Well, now that |
|
I was talking about people who create new GUI plugins (like the console ui) |
morinted
approved these changes
Apr 5, 2021
|
Ah. Yes, they could end up with the same issue. We might be able to work around that by changing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Don't mutate the original configuration set, or changes won't be saved.
Closes #1180.
Pull Request Checklist