Update plugins, development and distributions requirements, and the distributions' Python version #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not needed now that PEP 518 is used.
Necessary so it's possible to update to the latest PyQt5 version (without loosing support for QtWebEngine).
Support newer versions of the wheel package.
|
Running the CircleCI build gives this error (when running the I've yet to get the requirements installed properly on my machine to run from source, I think I need to fixup my python installation. |
|
From source, the plugins manager fails to load: which I guess is intentional? |
|
Did you update the plugins manager to the latest version? |
|
Oh, yep, after installing requirements_plugins.txt, the issue's gone. I'll still have to investigate what's going on with the .app and QT. |
|
Trying to build the .app locally, If I do I saw you commented on a similar issue, did you find a solution? |
|
Yeah, but isn't picking up certifi from your user site? I think this work fine if osx/make_app.sh | 3 +++
plover_build_utils/get_pip.py | 2 ++
2 files changed, 5 insertions(+)
diff --git i/osx/make_app.sh w/osx/make_app.sh
index 1b741f88..5bb2a4bf 100644
--- i/osx/make_app.sh
+++ w/osx/make_app.sh
@@ -56,6 +56,9 @@ mkdir "$target_libs/site-packages"
# Add sitecustomize.py -- adds the above site-packages to our Python's sys.path
cp "$plover_dir/osx/app_resources/sitecustomize.py" "$target_libs/sitecustomize.py"
+# Prefetch get-pip using the system Python (to avoid SSL errors).
+get_pip --no-download
+
# Switch to target Python.
python="$PWD/$target_dir/$target_python"
unset __PYVENV_LAUNCHER__
diff --git i/plover_build_utils/get_pip.py w/plover_build_utils/get_pip.py
index 81d1cc88..09115078 100644
--- i/plover_build_utils/get_pip.py
+++ w/plover_build_utils/get_pip.py
@@ -12,6 +12,8 @@ def get_pip(args=None):
# Download `get-pip.py`.
script = download('https://bootstrap.pypa.io/get-pip.py',
'a883be89e37dbaaabe6a5d8dfa871d3dfa8b2f9e')
+ if args == ['--no-install']:
+ return
# Make sure wheels cache directory exists to avoid warning.
if not os.path.exists(WHEELS_CACHE):
os.makedirs(WHEELS_CACHE) |
|
sigh pebcak: Okay--patch not needed after that. I can recreate the |
So, sure enough QtDBus.framework is present in my system install but not included in the 5.11.2 is working so it seems like 5.11.3 introduced whatever is causing an issue here. |
|
And if you remove |
|
Confirmed, removing that from the blacklist and everything's working fine with the PR as-is. Thank you for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, the idea was to stay on PyQt5 5.9.x (since Qt 5.9 is supposed to be a LTS version), and only update to new point releases, but PyQt5 does not follow that, so we might as well update to the latest version.
Note: there's no QtWebEngine support with recent win32 builds of PyQt5, hence the switch to generating a 64bits distribution.
I've tested locally the new AppImage on Arch Linux and Ubuntu Trusty, and the new Windows installer/distribution on a Windows 10 VM, someone need to test the macOS image.