steno_dictionary: fix StenoDictionaryCollection.casereverse_lookup
#1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't stop at the first result, potentially ignoring lower priority dictionaries. This also tweak the `StenoDictionary` code to be slightly faster on load.
|
Is it possible returning a set will break some external usage in plugins? I guess only if they were mutating the returned value. Should be okay right? |
|
I think it should be okay, yes. Better to change the API now than after 4.0.0 in any case! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't stop at the first result, potentially ignoring lower priority dictionaries. This also tweak the
StenoDictionarycode to be slightly faster on load.Timings:
main.json(4.02 MiB, 147424 entries):0.781s->0.625sgerman_palantype.json(58.29 MiB, 1466824 entries):13.492s->10.511s5.053s->4.177smagnum.rtf(45.8 MiB, 616946 entries):22.953s->22.731s(yes RTF is still slow as hell, much better with the new parser:14.338s)