-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make using builtin commands / metas more user-friendly. #1069
Make using builtin commands / metas more user-friendly. #1069
Conversation
c6d2076
to
1de9ee4
Compare
1de9ee4
to
2af1fd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the behavior of {:attach}
? Would it be like {:attach:^ing}
, with {:attach:word}
having no effect?
We may also consider |
2af1fd9
to
bc05c44
Compare
def test_meta_attach_4(self):
r'''
'TEFT': 'test',
'AT': '{:attach:attach}',
TEFT/AT ' test attach'
''' |
Sure, do if you think it's clearer, do you want me to change it? |
Regarding the behavior of |
I like both of these suggestions if you want to add the changes to this PR |
Using the `{:meta:args}` syntax.
If not specified, attach at both ends.
bc05c44
to
c6cf137
Compare
@morinted: I changed the default for |
Thanks for the changes. I think "affix" is more technically correct, but "attach" will probably be easier to understand for users. Let's merge as-is. |
Add user-friendly names for builtin metas (e.g.
{:retro_currency:$c}
), and ignore case when processing builtins commands / metas (so{PloveR:toggle}
or{:mode:Camel}
will work as expected).Fix #688 and #870.