Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes #1161. Depends on #1276 (included).
How it works:
{#combo}
key combo now can end with keys left in the pressed state{##combo}
key combo syntax allow continuing a preceding comboI ended up moving some of the key combo handling one level higher, in the engine: the
KeyboardEmulation.send_key_combination
method no expect a pre-parsed list of event to send (pairs of[pressed: boolean, key_code]
), parsing and validation is done in the engine.Because the Windows implementation does not monitor keyboard layout changes though events, but instead would refresh the layout before sending a key combo / backspaces / string, the output instance can now be used as a context manager:
The layout is refreshed on
__enter__
on Windows. And on Linux,display.sync()
is called at__exit__
.The (keyboard) machine suppression now has 3 possible modes:
SUPPRESSION_NONE
: no suppression (e.g. when output is disabled)SUPPRESSION_PARTIAL
: only suppress some keys (standard mode when output is enabled)SUPPRESSION_FULL
: full suppress the keyboard: only used while a combo is active (held keys)TODO:
Pull Request Checklist