Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: update French translation #1422

Merged

Conversation

jeandeaual
Copy link
Contributor

@jeandeaual jeandeaual commented Oct 16, 2021

Summary of changes

  • Updated the French translation
    • Added missing translations
    • Updated a few translations
    • Minor typographic fixes (spaces before colon, removed double spaces...)

Pull Request Checklist

  • Changes have tests
  • News fragment added in news.d. See documentation for details

Copy link
Member

@benoit-pierre benoit-pierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci.

Looking good, a few nitpicks.

plover/messages/fr/LC_MESSAGES/plover.po Outdated Show resolved Hide resolved
plover/messages/fr/LC_MESSAGES/plover.po Outdated Show resolved Hide resolved
plover/messages/fr/LC_MESSAGES/plover.po Outdated Show resolved Hide resolved
plover/messages/fr/LC_MESSAGES/plover.po Outdated Show resolved Hide resolved
plover/messages/fr/LC_MESSAGES/plover.po Outdated Show resolved Hide resolved
plover/messages/fr/LC_MESSAGES/plover.po Outdated Show resolved Hide resolved
plover/messages/fr/LC_MESSAGES/plover.po Outdated Show resolved Hide resolved
plover/messages/fr/LC_MESSAGES/plover.po Outdated Show resolved Hide resolved
plover/messages/fr/LC_MESSAGES/plover.po Outdated Show resolved Hide resolved
plover/messages/fr/LC_MESSAGES/plover.po Outdated Show resolved Hide resolved
jeandeaual and others added 2 commits October 16, 2021 17:58
Co-authored-by: Benoit Pierre <benoit.pierre@gmail.com>
@jeandeaual
Copy link
Contributor Author

Thanks for the review! I applied your suggestions and removed the old unused translations from the file.

Copy link
Member

@benoit-pierre benoit-pierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there.

#, fuzzy
#| msgid "Save strokes to the logfile."
msgid "Path to the log file."
msgstr "Enregistre les accords dans le journal."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that one: that automatic fuzzy translation does not make sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. That translation is supposed to be for plover/gui_qt/config_window.py:347.

#, fuzzy
#| msgid "Save strokes to the logfile."
msgid "Open a file picker to select the log file."
msgstr "Enregistre les accords dans le journal."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@@ -295,82 +393,82 @@ msgstr ""
"Défini le sens d'affichage des dictionnaires :\n"
"- haut-en-bas : correspond à l'ordre de recherche; par priorité "
"décroissante\n"
"- bas-en-haut: dans l'ordre inverse de recherche; par priorité croissante\n"
"- bas-en-haut: dans l'ordre inverse de recherche; par priorité croissante\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"- bas-en-haut: dans l'ordre inverse de recherche; par priorité croissante\n"
"- bas-en-haut : dans l'ordre inverse de recherche; par priorité croissante\n"

#: plover/gui_qt/dictionaries_widget_ui.py:130
#. Widget: “DictionariesWidget”, tool tip.
#: plover/gui_qt/dictionaries_widget.py:636
#: plover/gui_qt/dictionaries_widget_ui.py:139
msgid "Add dictionaries"
msgstr "Ajouter des dictionnaires"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "Ajouter des dictionnaires"
msgstr "Ajoute des dictionnaires"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do the same for &Ajouter des dictionnaires, Ajouter une traduction and other infinitives?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to use the infinitive for labels, and the third person present tense for tooltips (as in "(un clique sur ce bouton) ouvre la fenêtre de traduction"), but I'm wondering now if that's a good idea... Clearly "Ouvrir" is how "Open" is commonly translated in applications, so maybe it would be better to stick to the infinitive in all cases. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that both the infinitive and third person is used for tooltips, depending on the application.
I agree that using the third person makes sense in this context, so I fixed this and another tooltip text that was using the infinitive.

Copy link
Member

@benoit-pierre benoit-pierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks.

@benoit-pierre benoit-pierre merged commit eab3934 into openstenoproject:master Oct 17, 2021
@jeandeaual jeandeaual deleted the french-translation-update branch October 17, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants