-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: update French translation #1422
i18n: update French translation #1422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci.
Looking good, a few nitpicks.
Co-authored-by: Benoit Pierre <benoit.pierre@gmail.com>
Thanks for the review! I applied your suggestions and removed the old unused translations from the file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there.
#, fuzzy | ||
#| msgid "Save strokes to the logfile." | ||
msgid "Path to the log file." | ||
msgstr "Enregistre les accords dans le journal." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that one: that automatic fuzzy translation does not make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that. That translation is supposed to be for plover/gui_qt/config_window.py:347
.
#, fuzzy | ||
#| msgid "Save strokes to the logfile." | ||
msgid "Open a file picker to select the log file." | ||
msgstr "Enregistre les accords dans le journal." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
@@ -295,82 +393,82 @@ msgstr "" | |||
"Défini le sens d'affichage des dictionnaires :\n" | |||
"- haut-en-bas : correspond à l'ordre de recherche; par priorité " | |||
"décroissante\n" | |||
"- bas-en-haut: dans l'ordre inverse de recherche; par priorité croissante\n" | |||
"- bas-en-haut: dans l'ordre inverse de recherche; par priorité croissante\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"- bas-en-haut: dans l'ordre inverse de recherche; par priorité croissante\n" | |
"- bas-en-haut : dans l'ordre inverse de recherche; par priorité croissante\n" |
#: plover/gui_qt/dictionaries_widget_ui.py:130 | ||
#. Widget: “DictionariesWidget”, tool tip. | ||
#: plover/gui_qt/dictionaries_widget.py:636 | ||
#: plover/gui_qt/dictionaries_widget_ui.py:139 | ||
msgid "Add dictionaries" | ||
msgstr "Ajouter des dictionnaires" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "Ajouter des dictionnaires" | |
msgstr "Ajoute des dictionnaires" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do the same for &Ajouter des dictionnaires
, Ajouter une traduction
and other infinitives?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea was to use the infinitive for labels, and the third person present tense for tooltips (as in "(un clique sur ce bouton) ouvre la fenêtre de traduction"), but I'm wondering now if that's a good idea... Clearly "Ouvrir" is how "Open" is commonly translated in applications, so maybe it would be better to stick to the infinitive in all cases. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that both the infinitive and third person is used for tooltips, depending on the application.
I agree that using the third person makes sense in this context, so I fixed this and another tooltip text that was using the infinitive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, thanks.
Summary of changes
Pull Request Checklist