Fix "Add Translation" formatted translation & raw strokes always using a white background color #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the stylesheet resets the palette colors to the system default. For the base color, that'd mean that it'd be reset to `#ffffff`. While setting the palette from the stylesheet could be done, it's much simpler to instead let the formatted text inherit the background color.
DropDemBits
force-pushed
the
add-translation-bkg-colors
branch
from
dbfadc7 to
8175897
Compare
|
For reference the commit that adds that part was 9f1bdde. Seems there's no specific rationale for the background part in particular. Side note, even with that removed the style is still hard coded i.e. not configurable with qss I think? Probably not a big issue either way |
user202729
approved these changes
Jun 27, 2023
sammdot
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Setting the stylesheet resets the palette colors to the system default. For the base color (which was used by the span for the formatted translation & raw stroke text), that'd mean that it'd be reset to
#ffffff.While setting the palette from the stylesheet could be done, it's much simpler to instead let the formatted text inherit the background color (i.e. removing the explicit setting of the background color).
Closes #1569
Pull Request Checklist
Changes have testsN/A, UI change