Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows Tests #1599

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Fix Windows Tests #1599

merged 2 commits into from
Jul 14, 2023

Conversation

Robberduckzilla
Copy link
Contributor

@Robberduckzilla Robberduckzilla commented Mar 12, 2023 •
edited
Loading

Summary of changes

Normalized filepath name to fix bug with windows tests

Pull Request Checklist

  • Changes have tests
  • News fragment added in news.d.

@Robberduckzilla Robberduckzilla marked this pull request as ready for review March 12, 2023 18:38
@mkrnr
Copy link
Contributor

mkrnr commented Apr 1, 2023

I can confirm that before this fix, the test test\gui_qt\test_dictionaries_widget.py failed on Windows 11 x64 and after this fix all tests pass.

Looks good to me ✅

This was referenced Apr 28, 2023
Merged
Open
@sammdot sammdot merged commit 32489ae into openstenoproject:master Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sammdot sammdot sammdot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Robberduckzilla @mkrnr @sammdot