-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the HID Protocol. #1693
base: main
Are you sure you want to change the base?
Conversation
If I understood correctly this is just copy pasted from the plugin https://github.com/dnaq/plover-machine-hid/blob/main/plover_machine_hid.py (with the goal to make it available by default in Plover). Technically nothing wrong (the original repository uses MIT license which allows code to be used in HID) The motivation is to use a custom protocol over Bluetooth to allow using the standard keyboard… but this may be better off just implementing keyboard selection into Plover in the first place. |
I support this PR. Let's get this merged! |
This PR needs adding the hidapi libraries to the release files as well for it to work. |
What about adding the plugin to the default plugins and shipping it with releases? Same effect, but keeps the code ownership and parallel development intact? |
Sounds like a perfectly good plan, then the only thing to do in mainline plover would be to make sure hidapi is bundled in the release images (and also to make sure that the machine type is defined so we can set a default keymap). |
Yes, if I remember correctly, that was the original plan. I was having trouble bundling HID with the Mac release—someone would need to take that on. |
You'll also want to copy over hid_option.py, so that you can configure things like repeat delay from the Plover UI. It'll look like this: |
@morinted I have a Mac, is there any way I can help? |
Summary of changes
This PR adds a new protocol called Hid which works over BLE and USB.
Other protocols can't be used over BLE which this aims to solve.
Closes 1693
Pull Request Checklist