Skip to content

Commit

Permalink
clearer labels for OSM links in history panel (#8834)
Browse files Browse the repository at this point in the history
  • Loading branch information
jasonghent98 authored Dec 7, 2021
1 parent 144f3e9 commit 8111e5d
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 3 additions & 1 deletion data/core.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -643,8 +643,10 @@ en:
last_edit: Last Edit
edited_by: Edited By
changeset: Changeset
changeset_link: Changeset on osm.org
profile_link: Profile on osm.org
history_link: History on osm.org
unknown: Unknown
link_text: History on openstreetmap.org
note_no_history: "No History (New Note)"
note_comments: Comments
note_created_date: Created Date
Expand Down
2 changes: 1 addition & 1 deletion dist/locales/en.min.json

Large diffs are not rendered by default.

8 changes: 3 additions & 5 deletions modules/ui/panels/history.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export function uiPanelHistory(context) {
.attr('class', 'user-osm-link')
.attr('href', osm.userURL(userName))
.attr('target', '_blank')
.text('OSM');
.call(t.append('info_panels.history.profile_link'));
}

links
Expand Down Expand Up @@ -76,7 +76,7 @@ export function uiPanelHistory(context) {
.attr('class', 'changeset-osm-link')
.attr('href', osm.changesetURL(changeset))
.attr('target', '_blank')
.text('OSM');
.call(t.append('info_panels.history.changeset_link'));
}

links
Expand All @@ -98,7 +98,6 @@ export function uiPanelHistory(context) {
function redraw(selection) {
var selectedNoteID = context.selectedNoteID();
osm = context.connection();

var selected, note, entity;
if (selectedNoteID && osm) { // selected 1 note
selected = [ t.html('note.note') + ' ' + selectedNoteID ];
Expand Down Expand Up @@ -198,8 +197,7 @@ export function uiPanelHistory(context) {
.attr('class', 'view-history-on-osm')
.attr('href', osm.historyURL(entity))
.attr('target', '_blank')
.attr('title', t('info_panels.history.link_text'))
.text('OSM');
.call(t.append('info_panels.history.history_link'));
}
links
.append('a')
Expand Down

0 comments on commit 8111e5d

Please sign in to comment.