Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This makes the osmNote work a bit more like other osm objects in iD. - When working with the osm objects, we'll treat them as immutable. So all modifications will be through the update method: e.g. can do this in a repl, like chrome devtools console: > n = iD.osmNote() osmNote { id: -1 } > n = n.update({ foo: 'bar' }); osmNote { foo: "bar", id: -1, v: 1 } - none of the other osm objects have getters, and in JavaScript all the properties are public anyway
- Loading branch information
ede5610
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhousel this makes a lot of sense. These getters weren't being used yet anyways, but this helps clarify how updates work. Thanks!