Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Way can be reasonably assumed to not be oneway. #2220

Closed
matkoniecz opened this issue May 11, 2014 · 7 comments
Closed

Way can be reasonably assumed to not be oneway. #2220

matkoniecz opened this issue May 11, 2014 · 7 comments

Comments

@matkoniecz
Copy link
Contributor

Currently on editing road without oneway tag "One Way Unknown" is presented. It encourages adding useless tag "oneway=no" everywhere (I did it at start).

It would be better to display "Assumed to be no" instead of "Unknown".

@matkoniecz matkoniecz changed the title One way can be reasonably assumed to be no Way can be reasonably assumed to not be oneway. May 11, 2014
@bhousel
Copy link
Member

bhousel commented May 19, 2014

Agreed, now the oneway field will not show the unknown option.

@bhousel bhousel closed this as completed May 19, 2014
@jfirebaugh
Copy link
Member

I'd rather go with @mkoniecz's suggestion of changing the placeholder text to "Assumed to be no" than changing the field type to defaultcheck. There are a few cases where oneway=no is useful: in order to avoid mapping errors in areas where oneway streets are common and to override the assumed default of oneway=yes on things like junction=roundabout and highway=motorway.

@jfirebaugh jfirebaugh reopened this May 19, 2014
bhousel added a commit that referenced this issue May 19, 2014
@bhousel
Copy link
Member

bhousel commented May 19, 2014

Ok. We'll need to fix the check field to support changing the placeholder text, but that's probably easy.

Also I noticed that junction=roundabout with oneway=no still renders the oneway markers. I can fix iD.Way.isOneWay() so it returns false if oneway is explicitly tagged falsy.

@jfirebaugh
Copy link
Member

👍 Sounds great!

@matkoniecz
Copy link
Contributor Author

Note that junction=roundabout and highway=motorway (and maybe other?) should display "Assumed to be yes".

Is it possibly to modify it so isOneWay and tagging interface will check single source to get default onewayness?

bhousel added a commit that referenced this issue May 20, 2014
i.e. overrides implied oneway tag like `highway=motorway` or `junction=roundabout`
@bhousel
Copy link
Member

bhousel commented May 21, 2014

Note that junction=roundabout and highway=motorway (and maybe other?) should display "Assumed to be yes".

For highway=motorway, I think iD tries to add an explicit oneway=yes tag. (wiki suggests this is good behavior).

For junction=roundabout this is trickier because we don't have an actual preset field for it. There is some discussion on #1841, #2062, #1264. If we create it as a preset, we would need to add one for every kind of highway. If we create it as a field on the highways, we'd really want it to only show up for closed highway=* ways, which fields can't currently do. (Edit: or maybe not, since a roundabout could really be made up of a bunch of non-closed ways connected together?). Roundabouts/jughandles may work better as an enhancement on the turning restrictions that @jfirebaugh is working on, rather than trying to fit them into the existing preset/field ui.

Is it possibly to modify it so isOneWay and tagging interface will check single source to get default onewayness?

I could make a global Object similar to area_keys (oneway_keys?) if the onewayness really is used in a few places.

@bhousel
Copy link
Member

bhousel commented May 23, 2014

Is it possibly to modify it so isOneWay and tagging interface will check single source to get default onewayness?

I could make a global Object similar to area_keys (oneway_keys?) if the onewayness really is used in a few places.

I ended up doing this because it turned out that there are a few places where we want to check for implied onewayness, and it turns out that there are more tags that imply onewayness than I realized (piste stuff, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants