-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to support marine focused "fuel" tag #2589
Comments
so it seems that the seamark tag is the better one, yes? |
The seamark:small_craft_facility:category tag takes a semicolon separated list, and is So while the numbers are higher, it's not clear if the tag is actually better. A pragmatic solution is to tag both, not trying to predict a winner, but helping support the mapping of the feature. harbour=fuel_station is another possible tag. |
Any idea how often Between the two tags listed, I'd prefer |
@pnorman It's rare that amenity=fuel is used on water. Mostly the Marina fuel stations are not mapped. If you mean to make the rendering clear by context, I think that's too hard. A Marina might have a gas station plus a marine fuel station, both in proximity to the water's edge. Marine fuel stations are invariably on a floating dock, and thus for new mapping can reasonably be tagged on a node of a man_made=pier. That pier should be drawn over water, but often extends to land. |
Oh, I see. Yeah the iD presets are not able to adjust specific values inside a semicolon separated list and that not something we will support.
|
Yes, I added the stub. It's in use, it makes sense, and it sets a nice pattern (amenity=fuel/waterway=fuel, amenity=sanitary_dump_station/waterway=sanitary_dump_station). This is a case of structuring data well for later rendering. |
I'm downloading the data, I suspect water and land-based fuel stations are tagged the same. |
@pnorman I'm interested in your results. Note the past is not to be ignored, but a preset is about future tagging. If fuel stations are tagged as amenity=fuel, it's probably because that's all that renders. The downside is someone types "show me a nearby gas station" in OSMAnd, and they have a bad experience with OSM data. A semi-mechanical edit can probably hit several 9's on separating out the feature. |
@pnorman unfortunately there are marine facilities that are on land like https://www.openstreetmap.org/node/853853620/history . Proximity alone can't reliability make the distinction. |
165 amenity=fuel points or polygons intersecting the ocean. I didn't think to include So, my preference would be for |
@pnorman that count of 165 is .6% of the total mapped fuel stations. You've got a probably large undercount, as most freshwater marinas use some combo like natural=water. How many of those are rendering-hacked amenity=fuel + waterway=fuel? We won't know the true mapper preferences on this issue until waterway=fuel renders in osm-carto. The lack of rendering no doubt pushes people to other tags. Would you support starting at osm-carto, and then circling back to a preset after a year or so? Note the same issue presents itself for aviation fuel... only it's harder to disambiguate as both land & aviation fuel are sold at airports. |
It's not an established tag. Tags have been getting established without presets or renderer support for a long time, so this isn't necessary for tagging to become settled. |
It's not necessary, but it's terribly helpful, especially in the iD context. A new powerboat enthusiast coming to the map is clearly either going to be confused (why the fuel station did not show up), or guided to using amenity=fuel. But that is a separate discussion from the iD tag. For now I retagged a few name=Boat fuel (with no other tags) to waterway=fuel. It's usually possible to tell which amenity=fuel could be waterway=fuel, but without rendering people will feel like something was deleted. |
There's a lot of this out there also: |
Note I was concerned that OpenSeaMap might object to this tagging. Turns out the |
I used seamark:type=bunker_station (https://www.openstreetmap.org/node/3257385215#map=19/44.30195/9.21109) but I could switch to another tag :-) |
@sabas there are only seven (7) bunker stations in the OSM data. Bunker also implies bunker fuel oil, which is for heavy ships, and not used for small craft. The JOSM editor implements waterway=fuel. OpenSeaMap uses and renders fuel_station if it is one of the values in a seamark:small_craft_facility:category tag. It's pretty rare to have a single fuel pump with long enough hose to serve boats and cars. But if so just tag:
|
Thanks @brycenesbitt! |
The iD editor presently supports tagging of amenity=fuel, calling it a gas station in English.
This is a request to support tagging of a marine fuel facility. These are not interchangeable features. There are two candidate tags for this:
seamark:small_craft_facility:category=fuel_station
waterway=fuel
Note that separate amenity=fuel and waterway=fuel may exist within the same leisure=marina. So proximity is not enough to determine the facility type.
The text was updated successfully, but these errors were encountered: