Cannot open Minimap on Non-US keyboards

[tyrasd]

The keyboard shortcut to open the minimap (#2554) is the slash / character, which is input on a German keyboard layout via shift+7. iD doesn't trigger the minimap-toggle when pressing this key combo. Strangely, pressing the # character on a German keyboard opens the minimap on Chrome, but not on Firefox.

I'm assuming this is because of using the keyCode property here, which seems to be a bit broken:

Web developers shouldn't use the keycode attribute for printable characters […] especially those input with the Shift or Alt key pressed. When implementing a shortcut key handler, the keypress event is usually better.

[bhousel]

Hmm, yeah keycode detection is kind of broken.

It's hacky, but maybe for now (in lieu of changing d3.keybinding) we can find a keycode on the German keyboard that isn't used for anything.

What codes do you get when you visit this jsfiddle, and try keys like ä,ö,ü,ß
http://jsfiddle.net/YKeye/

[tyrasd]

character	keycode (chromium)	keycode (firefox)	keycode (old presto based opera)
/	55 (then 16 on releasing the shift key)	55 (then 16)	55 (then 16)
ä	222	0	222
ö	192	0	186
ü	186	0	219
ß	219	63	109

It's a mess! 💩

[Abbe98]

This is broken using Swedish and Norwegian keyboards too.

[bhousel]

I did some research today, and yeah it's a mess. This will hopefully get better when DOM Level 3 Keyboard Events are implemented in all browsers, but that's a long way off.

For now some decent resources are Unixpapa's summary and this implementation by the noVNC developer.

[bhousel]

Check French keyboard too, per #3660

[manfredbrandl]

at the latest preview '/' (Shift-7) now works on my German keyboard

[magol]

And it works on Swedish keyboard to 😀

[tyrasd]

perfect